Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend interface for collStats #3294

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Add backend interface for collStats #3294

merged 4 commits into from
Sep 1, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 31, 2023 •
edited
Loading

Description

Closes #3259.

This PR is about interface, implementation will follow in next PR.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Aug 31, 2023
@chilagrow chilagrow self-assigned this Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #3294 (a08f4ae) into main (de67252) will decrease coverage by 0.11%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3294      +/-   ##
==========================================
- Coverage   75.23%   75.13%   -0.11%     
==========================================
  Files         400      400              
  Lines       23007    23018      +11     
==========================================
- Hits        17310    17294      -16     
- Misses       4696     4717      +21     
- Partials     1001     1007       +6
Files Changed Coverage
internal/backends/collection.go 0.00%
internal/backends/postgresql/collection.go 0.00%
internal/backends/postgresql/database.go 0.00%
internal/backends/sqlite/collection.go 0.00%
internal/backends/database.go 100.00%
internal/backends/sqlite/database.go 100.00%
internal/handlers/sqlite/msg_dbstats.go 100.00%
Flag Coverage Δ
hana ?
integration 71.68% <25.00%> (-0.09%) ⬇️
mongodb 5.14% <0.00%> (-0.01%) ⬇️
pg 62.94% <0.00%> (-0.03%) ⬇️
shard-1 55.96% <25.00%> (-0.12%) ⬇️
shard-2 54.74% <25.00%> (-0.03%) ⬇️
shard-3 55.86% <25.00%> (-0.03%) ⬇️
sqlite 54.79% <25.00%> (-0.08%) ⬇️
unit 25.03% <18.75%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow force-pushed the issue-3259-collstats-sqlite branch from 464ad13 to 894798e Compare August 31, 2023 09:41
@chilagrow chilagrow added this to the Next milestone Aug 31, 2023
@chilagrow chilagrow marked this pull request as ready for review August 31, 2023 09:46
@chilagrow chilagrow requested a review from AlekSi as a code owner August 31, 2023 09:46
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup August 31, 2023 09:46
@chilagrow chilagrow enabled auto-merge (squash) August 31, 2023 09:47
@chilagrow chilagrow requested a review from a team as a code owner September 1, 2023 02:18
@chilagrow chilagrow requested a review from AlekSi September 1, 2023 02:20
@chilagrow chilagrow mentioned this pull request Sep 1, 2023
Merged
9 tasks
rumyantseva
rumyantseva previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, the code looks consistent and easy to understand, great job!

@AlekSi AlekSi disabled auto-merge September 1, 2023 10:38
@AlekSi AlekSi merged commit 65db99f into FerretDB:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement dbStats and collStats for SQLite
3 participants
@chilagrow @AlekSi @rumyantseva