Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make registry return full collection info #3292

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Make registry return full collection info #3292

merged 4 commits into from
Aug 31, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 31, 2023 •
edited
Loading

Description

For #3270.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Aug 31, 2023
@AlekSi AlekSi mentioned this pull request Aug 31, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #3292 (4655a6d) into main (bdfdace) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
+ Coverage   75.16%   75.19%   +0.03%     
==========================================
  Files         400      400              
  Lines       22901    22901              
==========================================
+ Hits        17213    17220       +7     
+ Misses       4691     4687       -4     
+ Partials      997      994       -3
Files Changed Coverage
internal/backends/sqlite/database.go 100.00%
internal/backends/sqlite/metadata/registry.go 100.00%
Flag Coverage Δ
hana ?
integration 71.64% <100.00%> (+0.02%) ⬆️
mongodb 5.16% <0.00%> (ø)
pg 63.24% <0.00%> (-0.04%) ⬇️
shard-1 55.79% <100.00%> (-0.07%) ⬇️
shard-2 54.55% <100.00%> (-0.06%) ⬇️
shard-3 55.94% <100.00%> (ø)
sqlite 54.69% <100.00%> (+0.05%) ⬆️
unit 24.94% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Aug 31, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 31, 2023
@AlekSi AlekSi marked this pull request as ready for review August 31, 2023 05:16
@AlekSi AlekSi enabled auto-merge (squash) August 31, 2023 05:16
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup August 31, 2023 05:16
chilagrow
chilagrow approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

rumyantseva
rumyantseva approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 37c183e into FerretDB:main Aug 31, 2023
@AlekSi AlekSi deleted the list-info branch August 31, 2023 07:04
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Make registry return full collection info (FerretDB#3292)
9ed63ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow