Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deletes atomic for SQLite #3291

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Make deletes atomic for SQLite #3291

merged 5 commits into from
Aug 31, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 30, 2023 •
edited
Loading

Description

Closes #3085.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Aug 30, 2023
@AlekSi AlekSi added this to the Next milestone Aug 30, 2023
@AlekSi AlekSi self-assigned this Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3291 (7efeec7) into main (8548d92) will increase coverage by 0.03%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.03%     
==========================================
  Files         400      400              
  Lines       22883    22901      +18     
==========================================
+ Hits        17203    17225      +22     
+ Misses       4686     4682       -4     
  Partials      994      994
Files Changed Coverage
integration/helpers.go 0.00%
internal/backends/collection.go ø
internal/backends/sqlite/collection.go 70.58%
internal/handlers/sqlite/msg_delete.go 92.85%
internal/types/array.go 100.00%
internal/types/document.go 100.00%
Flag Coverage Δ
hana ?
integration 71.68% <78.26%> (+0.04%) ⬆️
mongodb 5.16% <0.00%> (-0.01%) ⬇️
pg 63.27% <0.00%> (-0.05%) ⬇️
shard-1 55.91% <52.17%> (+<0.01%) ⬆️
shard-2 54.66% <52.17%> (+<0.01%) ⬆️
shard-3 55.94% <78.26%> (+<0.01%) ⬆️
sqlite 54.70% <78.26%> (+0.01%) ⬆️
unit 24.94% <9.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review August 30, 2023 19:07
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners August 30, 2023 19:07
@AlekSi AlekSi enabled auto-merge (squash) August 30, 2023 19:07
@AlekSi AlekSi requested review from a team and noisersup August 30, 2023 19:07
chilagrow
chilagrow approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@AlekSi AlekSi disabled auto-merge August 31, 2023 03:48
@AlekSi AlekSi merged commit bdfdace into FerretDB:main Aug 31, 2023
@AlekSi AlekSi deleted the sqlite-delete branch August 31, 2023 03:48
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Make deletes atomic for SQLite (FerretDB#3291)
276b95b 
Closes FerretDB#3085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Cleanup deletes
2 participants
@AlekSi @chilagrow