Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand architecture docs, add comments #3288

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Expand architecture docs, add comments #3288

merged 1 commit into from
Aug 30, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 30, 2023

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 30, 2023
@AlekSi AlekSi added this to the Next milestone Aug 30, 2023
@AlekSi AlekSi self-assigned this Aug 30, 2023
@AlekSi AlekSi marked this pull request as ready for review August 30, 2023 13:35
@AlekSi AlekSi requested a review from a team as a code owner August 30, 2023 13:35
@AlekSi AlekSi enabled auto-merge (squash) August 30, 2023 13:35
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 30, 2023
@AlekSi AlekSi requested review from a team and noisersup August 30, 2023 13:35
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3288 (7e273b1) into main (a6591d2) will decrease coverage by 0.04%.
The diff coverage is 65.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3288      +/-   ##
==========================================
- Coverage   75.20%   75.16%   -0.04%     
==========================================
  Files         400      400              
  Lines       22872    22883      +11     
==========================================
+ Hits        17200    17201       +1     
- Misses       4679     4686       +7     
- Partials      993      996       +3
Files Changed Coverage
internal/backends/postgresql/collection.go 0.00%
internal/handlers/sqlite/msg_collmod.go 0.00%
internal/handlers/sqlite/sqlite.go ø
internal/types/array.go ø
internal/types/document.go ø
internal/backends/sqlite/collection.go 50.00%
internal/backends/collection.go 100.00%
internal/handlers/sqlite/msg_datasize.go 100.00%
internal/handlers/sqlite/msg_delete.go 100.00%
internal/handlers/sqlite/msg_dropindexes.go 100.00%
... and 3 more
Flag Coverage Δ
hana ?
integration 71.64% <65.00%> (-0.02%) ⬇️
mongodb 5.17% <0.00%> (-0.01%) ⬇️
pg 63.32% <0.00%> (+<0.01%) ⬆️
shard-1 55.90% <65.00%> (-0.03%) ⬇️
shard-2 54.65% <60.00%> (+0.05%) ⬆️
shard-3 55.93% <60.00%> (+0.01%) ⬆️
sqlite 54.68% <65.00%> (-0.04%) ⬇️
unit 24.93% <15.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlekSi AlekSi disabled auto-merge August 30, 2023 17:20
@AlekSi AlekSi merged commit 8548d92 into FerretDB:main Aug 30, 2023
@AlekSi AlekSi deleted the clarify-arch branch August 30, 2023 17:20
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Expand architecture docs, add comments (FerretDB#3288)
48beabd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva