Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for validation bug #3286

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Add tests for validation bug #3286

merged 2 commits into from
Aug 30, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 30, 2023 •
edited
Loading

Description

For #2804.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Aug 30, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 30, 2023
@AlekSi AlekSi added this to the Next milestone Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3286 (1a5d4be) into main (a6591d2) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3286      +/-   ##
==========================================
- Coverage   75.20%   75.17%   -0.04%     
==========================================
  Files         400      400              
  Lines       22872    22872              
==========================================
- Hits        17200    17193       -7     
- Misses       4679     4683       +4     
- Partials      993      996       +3
Flag Coverage Δ
hana ?
integration 71.63% <ø> (-0.03%) ⬇️
mongodb 5.17% <ø> (ø)
pg 63.35% <ø> (+0.03%) ⬆️
shard-1 55.88% <ø> (-0.05%) ⬇️
shard-2 54.64% <ø> (+0.04%) ⬆️
shard-3 55.92% <ø> (ø)
sqlite 54.66% <ø> (-0.06%) ⬇️
unit 24.93% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review August 30, 2023 12:27
@AlekSi AlekSi requested a review from a team as a code owner August 30, 2023 12:27
@AlekSi AlekSi enabled auto-merge (squash) August 30, 2023 12:27
@AlekSi AlekSi requested review from a team and noisersup August 30, 2023 12:27
rumyantseva
rumyantseva approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge August 30, 2023 13:49
@AlekSi AlekSi merged commit c2e5228 into FerretDB:main Aug 30, 2023
@AlekSi AlekSi deleted the update-bug branch August 30, 2023 13:49
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Add tests for validation bug (FerretDB#3286)
300765d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @rumyantseva