Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getLog for SQLite #3279

Merged
merged 24 commits into from
Sep 4, 2023
Merged

Implement getLog for SQLite #3279

merged 24 commits into from
Sep 4, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Aug 29, 2023 •
edited
Loading

Description

Closes #3261.

Note: The new implementation of getLog doesn't depend on a particular handler and can be reused in a universal handler.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Aug 29, 2023
@rumyantseva rumyantseva added the code/feature Some user-visible feature is not implemented yet label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #3279 (83a834b) into main (65db99f) will decrease coverage by 0.01%.
The diff coverage is 74.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3279      +/-   ##
==========================================
- Coverage   75.15%   75.14%   -0.01%     
==========================================
  Files         400      400              
  Lines       23018    23145     +127     
==========================================
+ Hits        17299    17393      +94     
- Misses       4715     4741      +26     
- Partials     1004     1011       +7
Files Changed Coverage
internal/backends/postgresql/backend.go 0.00%
internal/backends/postgresql/collection.go ø
internal/backends/sqlite/collection.go ø
internal/backends/sqlite/metadata/pool/pool.go 56.25%
internal/backends/sqlite/backend.go 60.00%
internal/handlers/sqlite/msg_getlog.go 78.50%
internal/backends/backend.go 100.00%
internal/backends/sqlite/metadata/registry.go 100.00%
internal/handlers/sqlite/sqlite.go 100.00%
Flag Coverage Δ
hana ?
integration 71.69% <74.81%> (+0.01%) ⬆️
mongodb 5.11% <0.00%> (-0.03%) ⬇️
pg 62.59% <0.00%> (-0.35%) ⬇️
shard-1 55.70% <7.40%> (-0.19%) ⬇️
shard-2 54.47% <9.62%> (-0.28%) ⬇️
shard-3 55.96% <74.81%> (+0.10%) ⬆️
sqlite 55.03% <74.81%> (+0.23%) ⬆️
unit 24.95% <8.88%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva marked this pull request as ready for review August 30, 2023 08:13
@rumyantseva rumyantseva requested a review from a team as a code owner August 30, 2023 08:13
@rumyantseva rumyantseva enabled auto-merge (squash) August 30, 2023 08:13
@rumyantseva rumyantseva requested review from a team and noisersup August 30, 2023 08:13
chilagrow
chilagrow previously approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@rumyantseva rumyantseva added the do not merge PRs that should not be merged label Aug 30, 2023
@rumyantseva
Copy link
Contributor Author

[upd] I set "do not merge" label because I'm going to continue working on the PR (to have backend name and version passed to getLog)

AlekSi
AlekSi reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set backend name and version

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Aug 30, 2023
@AlekSi AlekSi removed the request for review from noisersup August 30, 2023 08:48
chilagrow
chilagrow reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment 🤗

internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
@rumyantseva rumyantseva requested a review from chilagrow August 31, 2023 07:25
chilagrow
chilagrow previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AlekSi AlekSi added this to the Next milestone Aug 31, 2023
AlekSi
AlekSi requested changes Aug 31, 2023
View reviewed changes
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/backends/sqlite/metadata/registry.go Outdated Show resolved Hide resolved
internal/handlers/pg/pgdb/pool.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 1, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 1, 2023
chilagrow
chilagrow approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rumyantseva rumyantseva merged commit 122a57c into FerretDB:main Sep 4, 2023
@rumyantseva rumyantseva deleted the issue-3261-get-log branch September 4, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement getLog for SQLite
3 participants
@rumyantseva @AlekSi @chilagrow