Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement listDatabases for SQLite #3269

Merged
merged 15 commits into from
Sep 8, 2023
Merged

Implement listDatabases for SQLite #3269

merged 15 commits into from
Sep 8, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Aug 29, 2023 •
edited
Loading

Description

Closes #3260.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Aug 29, 2023
@rumyantseva rumyantseva added code/feature Some user-visible feature is not implemented yet do not merge PRs that should not be merged not ready Issues that are not ready to be worked on; PRs that should skip CI and removed do not merge PRs that should not be merged labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #3269 (1cf365e) into main (f3c4622) will increase coverage by 0.02%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
+ Coverage   74.42%   74.44%   +0.02%     
==========================================
  Files         406      406              
  Lines       24139    24154      +15     
==========================================
+ Hits        17965    17981      +16     
+ Misses       5108     5107       -1     
  Partials     1066     1066
Files Changed Coverage
internal/backends/sqlite/backend.go 44.44%
Flag Coverage Δ
integration 71.31% <44.44%> (+0.02%) ⬆️
mongodb 4.89% <0.00%> (-0.01%) ⬇️
pg 60.71% <0.00%> (-0.04%) ⬇️
shard-1 55.37% <44.44%> (+0.05%) ⬆️
shard-2 54.36% <44.44%> (+0.03%) ⬆️
shard-3 54.08% <44.44%> (+0.02%) ⬆️
sqlite 55.91% <44.44%> (+0.03%) ⬆️
unit 23.91% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!.

@rumyantseva rumyantseva removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 29, 2023
@rumyantseva rumyantseva marked this pull request as ready for review August 29, 2023 11:32
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners August 29, 2023 11:32
@rumyantseva rumyantseva requested review from chilagrow, a team and noisersup August 29, 2023 11:32
@rumyantseva rumyantseva enabled auto-merge (squash) August 29, 2023 11:33
@AlekSi AlekSi marked this pull request as draft August 30, 2023 04:49
auto-merge was automatically disabled August 30, 2023 04:49

Pull request was converted to draft

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Sep 1, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 1, 2023
@AlekSi AlekSi marked this pull request as draft September 4, 2023 04:39
auto-merge was automatically disabled September 4, 2023 04:39

Pull request was converted to draft

AlekSi
AlekSi reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On pause until we have dbStats/collStats to reduce the amount of conflicts

@mergify mergify bot removed the conflict PRs that have merge conflicts label Sep 7, 2023
@chilagrow chilagrow marked this pull request as ready for review September 7, 2023 03:32
@chilagrow chilagrow enabled auto-merge (squash) September 7, 2023 03:32
chilagrow
chilagrow previously approved these changes Sep 7, 2023
View reviewed changes
rumyantseva
rumyantseva commented Sep 7, 2023
View reviewed changes
Copy link
Contributor Author

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I can't approve though)

AlekSi
AlekSi reviewed Sep 7, 2023
View reviewed changes
internal/backends/sqlite/backend.go Show resolved Hide resolved
internal/backends/sqlite/backend.go Outdated Show resolved Hide resolved
internal/backends/sqlite/backend.go Outdated Show resolved Hide resolved
@chilagrow
Copy link
Member

chilagrow commented Sep 8, 2023 •
edited
Loading

SQLite tests will pass once #3327 is merged

@AlekSi AlekSi requested review from AlekSi, chilagrow and a team September 8, 2023 04:41
@AlekSi AlekSi added this to the Next milestone Sep 8, 2023
@rumyantseva
Copy link
Contributor Author

@chilagrow I think you need to approve yourself :)
I approve, but I don't have a button :)

@chilagrow
Copy link
Member

@chilagrow I think you need to approve yourself :) I approve, but I don't have a button :)

Yes 😅

@chilagrow chilagrow merged commit b032cd7 into FerretDB:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement listDatabases for SQLite
3 participants
@rumyantseva @chilagrow @AlekSi