Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to test for compatibility #3268

Merged
merged 38 commits into from
Sep 11, 2023
Merged

Document how to test for compatibility #3268

merged 38 commits into from
Sep 11, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Aug 29, 2023 •
edited
Loading

Description

Closes #3242.

So, I think this content would be categorized as "migration preparation" and would be a subsection to a complete migration guide.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the documentation Something user-visible is badly or not documented label Aug 29, 2023
@b1ron b1ron self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #3268 (e256e72) into main (1871dc9) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
- Coverage   74.49%   74.41%   -0.09%     
==========================================
  Files         406      406              
  Lines       24310    24310              
==========================================
- Hits        18110    18090      -20     
- Misses       5122     5140      +18     
- Partials     1078     1080       +2
Flag Coverage Δ
hana ?
integration 71.30% <ø> (-0.11%) ⬇️
mongodb ?
pg 60.29% <ø> (-0.03%) ⬇️
shard-1 55.15% <ø> (-0.25%) ⬇️
shard-2 53.97% <ø> (-0.01%) ⬇️
shard-3 54.29% <ø> (+0.10%) ⬆️
sqlite 56.10% <ø> (ø)
unit 23.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Thoughts on this report? Let us know!.

@b1ron b1ron added documentation Something user-visible is badly or not documented and removed documentation Something user-visible is badly or not documented labels Aug 29, 2023
@b1ron b1ron requested a review from Fashander August 29, 2023 11:11
@b1ron b1ron marked this pull request as ready for review August 30, 2023 12:59
@b1ron b1ron requested review from AlekSi and ptrfarkas as code owners August 30, 2023 12:59
@b1ron b1ron added the do not merge PRs that should not be merged label Aug 30, 2023
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Aug 30, 2023
@AlekSi AlekSi added this to the Next milestone Aug 30, 2023
@b1ron @Fashander
Update website/docs/migration.md
a621cc4 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@b1ron b1ron had a problem deploying to cloudflare-dev-docs August 30, 2023 13:52 — with GitHub Actions Failure
b1ron and others added 3 commits August 30, 2023 15:52
@b1ron @Fashander
Update website/docs/migration.md
ff5d767 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@b1ron @Fashander
Update website/docs/migration.md
dd609a0 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@b1ron
Merge branch 'main' into document-compat-process
c3f00ae
@b1ron b1ron had a problem deploying to cloudflare-dev-docs August 30, 2023 13:55 — with GitHub Actions Failure
@AlekSi AlekSi had a problem deploying to cloudflare-dev-docs September 4, 2023 13:38 — with GitHub Actions Failure
AlekSi
AlekSi reviewed Sep 4, 2023
View reviewed changes
website/docs/migration.md Outdated Show resolved Hide resolved
website/docs/migration.md Outdated Show resolved Hide resolved
website/docs/migration.md Outdated Show resolved Hide resolved
@b1ron b1ron requested a review from AlekSi September 4, 2023 16:41
AlekSi
AlekSi previously approved these changes Sep 5, 2023
View reviewed changes
website/docs/migration.md Outdated Show resolved Hide resolved
Fashander
Fashander approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on this! LGTM

@Fashander
Copy link
Member

I'll update this in the next PR so it's included in a general section on Migration, and then add a separate section for "migrating from MongoDB to FerretDB"

@Fashander Fashander closed this Sep 7, 2023
auto-merge was automatically disabled September 7, 2023 05:46

Pull request was closed

@Fashander Fashander reopened this Sep 7, 2023
@Fashander
Copy link
Member

Sorry @b1ron, I clicked by mistake

@AlekSi AlekSi self-requested a review September 7, 2023 18:10
@AlekSi AlekSi enabled auto-merge (squash) September 7, 2023 18:10
@AlekSi AlekSi disabled auto-merge September 11, 2023 07:25
@AlekSi AlekSi merged commit 17aed11 into FerretDB:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@b1ron b1ron

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Document compatibility checking process/tools
3 participants
@b1ron @Fashander @AlekSi