Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend interface for dbStats #3267

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Add backend interface for dbStats #3267

merged 6 commits into from
Aug 30, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 29, 2023 •
edited
Loading

Description

Closes #3259.

This PR is about backend interface used by dbStats. Implementation will be done in another PR.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Aug 29, 2023
@chilagrow chilagrow added this to the Next milestone Aug 29, 2023
@chilagrow chilagrow self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #3267 (2968ed5) into main (e9f6e90) will decrease coverage by 1.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
- Coverage   74.89%   72.95%   -1.94%     
==========================================
  Files         400      400              
  Lines       22788    22799      +11     
==========================================
- Hits        17066    16632     -434     
- Misses       4732     5166     +434     
- Partials      990     1001      +11
Files Changed Coverage
internal/backends/database.go 0.00%
internal/backends/postgresql/database.go 0.00%
internal/backends/sqlite/database.go 0.00%
Flag Coverage Δ
hana ?
integration 69.28% <0.00%> (-2.08%) ⬇️
mongodb 5.16% <0.00%> (-0.01%) ⬇️
pg 56.10% <0.00%> (-7.39%) ⬇️
shard-1 55.79% <0.00%> (+0.02%) ⬆️
shard-2 54.37% <0.00%> (-0.03%) ⬇️
shard-3 40.51% <0.00%> (-15.07%) ⬇️
sqlite 54.03% <0.00%> (+0.01%) ⬆️
unit 24.05% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Implements dbStats for SQLite Add backend interface for dbStats Aug 29, 2023
@chilagrow chilagrow changed the title Add backend interface for dbStats Add backend interface used by dbStats Aug 29, 2023
@chilagrow chilagrow marked this pull request as ready for review August 29, 2023 09:00
@chilagrow chilagrow requested a review from AlekSi as a code owner August 29, 2023 09:00
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup August 29, 2023 09:00
@chilagrow chilagrow enabled auto-merge (squash) August 29, 2023 09:00
@chilagrow chilagrow changed the title Add backend interface used by dbStats Add backend interface for dbStats Aug 29, 2023
AlekSi
AlekSi reviewed Aug 29, 2023
View reviewed changes
internal/backends/database.go Outdated Show resolved Hide resolved
internal/backends/database.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from AlekSi August 29, 2023 09:20
AlekSi
AlekSi previously approved these changes Aug 29, 2023
View reviewed changes
AlekSi
AlekSi reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be task fmt-ed

@AlekSi AlekSi changed the title Add backend interface for dbStats Add backend interface for dbStats Aug 29, 2023
rumyantseva
rumyantseva previously approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that fmt failed, but the new code looks consistent with the rest of backend database code to me.

@chilagrow chilagrow dismissed stale reviews from rumyantseva and AlekSi via d64a35d August 29, 2023 09:22
rumyantseva
rumyantseva approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Aug 29, 2023
noisersup
noisersup approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2023

update

✅ Branch has been successfully updated

@chilagrow chilagrow merged commit 0f91017 into FerretDB:main Aug 30, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@chilagrow @yonarw
Add backend interface used by dbStats (FerretDB#3267)
c495793 
Closes FerretDB#3259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement dbStats and collStats for SQLite
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup