Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement distinct for SQLite #3265

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 29, 2023

Description

Closes #3157.

We are not adding additional tests to allow us to implement SQLite faster. If you see codecov detecting untested cases, those will be tested once we move on to using one handler for all.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Aug 29, 2023
@chilagrow chilagrow added this to the Next milestone Aug 29, 2023
@chilagrow chilagrow self-assigned this Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3265 (3ffe4e0) into main (43b5a56) will decrease coverage by 0.06%.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
- Coverage   75.34%   75.28%   -0.06%     
==========================================
  Files         399      399              
  Lines       22633    22681      +48     
==========================================
+ Hits        17052    17076      +24     
- Misses       4599     4618      +19     
- Partials      982      987       +5     
Files Changed Coverage Δ
internal/handlers/sqlite/msg_distinct.go 58.00% <57.14%> (-42.00%) ⬇️

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 71.75% <57.14%> (-0.05%) ⬇️
mongodb 5.19% <0.00%> (-0.02%) ⬇️
pg 63.79% <0.00%> (-0.14%) ⬇️
shard-1 56.08% <57.14%> (-0.01%) ⬇️
shard-2 54.65% <51.02%> (-0.07%) ⬇️
shard-3 55.83% <10.20%> (-0.11%) ⬇️
sqlite 54.32% <57.14%> (+0.36%) ⬆️
unit 24.19% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review August 29, 2023 03:12
@chilagrow chilagrow requested a review from a team as a code owner August 29, 2023 03:12
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup August 29, 2023 03:12
@chilagrow chilagrow enabled auto-merge (squash) August 29, 2023 03:12
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. I see a couple of error cases that are not covered (invalid collection and invalid namespace), but they are minor, so I believe we can merge the PR to support distinct feature for SQLite ASAP.

@chilagrow chilagrow merged commit 2e847f0 into FerretDB:main Aug 29, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement distinct for SQLite
3 participants