-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement distinct
for SQLite
#3265
Implement distinct
for SQLite
#3265
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 75.34% 75.28% -0.06%
==========================================
Files 399 399
Lines 22633 22681 +48
==========================================
+ Hits 17052 17076 +24
- Misses 4599 4618 +19
- Partials 982 987 +5
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me. I see a couple of error cases that are not covered (invalid collection and invalid namespace), but they are minor, so I believe we can merge the PR to support distinct
feature for SQLite ASAP.
Description
Closes #3157.
We are not adding additional tests to allow us to implement SQLite faster. If you see codecov detecting untested cases, those will be tested once we move on to using one handler for all.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.