Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement explain command for SQLite #3264

Merged
merged 15 commits into from
Sep 4, 2023
Merged

Implement explain command for SQLite #3264

merged 15 commits into from
Sep 4, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 28, 2023 •
edited by rumyantseva
Loading

Description

Closes #3050.

I had some troubles with understanding what data should be outputted, as SQLite returns completely different data format and less information than pg

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Aug 28, 2023
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Aug 29, 2023
@AlekSi AlekSi added this to the Next milestone Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3264 (ed60e1e) into main (122a57c) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 46.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3264      +/-   ##
==========================================
- Coverage   75.13%   75.12%   -0.02%     
==========================================
  Files         400      400              
  Lines       23145    23201      +56     
==========================================
+ Hits        17391    17430      +39     
- Misses       4741     4752      +11     
- Partials     1013     1019       +6
Files Changed Coverage
internal/backends/collection.go ø
internal/handlers/sqlite/msg_explain.go 34.78%
internal/backends/sqlite/collection.go 53.65%
Flag Coverage Δ
hana ?
integration 71.68% <46.87%> (-0.02%) ⬇️
mongodb 5.09% <0.00%> (-0.02%) ⬇️
pg 62.44% <0.00%> (-0.16%) ⬇️
shard-1 55.67% <46.87%> (-0.05%) ⬇️
shard-2 54.50% <46.87%> (+0.02%) ⬆️
shard-3 55.96% <46.87%> (+<0.01%) ⬆️
sqlite 55.05% <46.87%> (+0.02%) ⬆️
unit 24.89% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi assigned rumyantseva and unassigned noisersup Aug 30, 2023
@rumyantseva rumyantseva requested review from a team, rumyantseva and chilagrow August 31, 2023 14:52
@rumyantseva rumyantseva marked this pull request as ready for review August 31, 2023 14:52
@rumyantseva rumyantseva requested review from AlekSi and a team as code owners August 31, 2023 14:52
@rumyantseva rumyantseva enabled auto-merge (squash) August 31, 2023 14:52
@rumyantseva rumyantseva changed the title Implement explain command for SQLite Implement explain command for SQLite Aug 31, 2023
chilagrow
chilagrow reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments 🤗

internal/handlers/sqlite/msg_explain.go Outdated Show resolved Hide resolved
internal/handlers/sqlite/msg_explain.go Outdated Show resolved Hide resolved
internal/backends/sqlite/collection.go Show resolved Hide resolved
chilagrow
chilagrow reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me!

Why is CI failing?

@rumyantseva
Copy link
Contributor

@chilagrow yeah, failing CI looks strange to me. Linters and unit tests pass locally...

@chilagrow
Copy link
Member

@chilagrow yeah, failing CI looks strange to me. Linters and unit tests pass locally...

I'm puzzled 🤔

@rumyantseva
Copy link
Contributor

Ok, I think something was lost when I was moving between PRs locally 😅

Now everything is back.

@rumyantseva rumyantseva requested a review from AlekSi September 1, 2023 14:45
chilagrow
chilagrow approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rumyantseva rumyantseva merged commit e3774a9 into FerretDB:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement basic explain for SQLite
4 participants
@noisersup @rumyantseva @chilagrow @AlekSi