Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TODO comments #3262

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Update TODO comments #3262

merged 3 commits into from
Aug 29, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 28, 2023 •
edited
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the code/chore Code maintenance improvements label Aug 28, 2023
@noisersup noisersup self-assigned this Aug 28, 2023
@noisersup noisersup marked this pull request as ready for review August 28, 2023 15:05
@noisersup noisersup requested a review from a team as a code owner August 28, 2023 15:05
@noisersup noisersup requested review from AlekSi, chilagrow, a team and rumyantseva August 28, 2023 15:05
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (e0b4073) to head (9ea3520).
Report is 628 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3262   +/-   ##
=======================================
  Coverage   75.17%   75.17%           
=======================================
  Files         400      400           
  Lines       22386    22386           
=======================================
  Hits        16829    16829           
  Misses       4580     4580           
  Partials      977      977
Files with missing lines Coverage Δ
internal/handlers/sqlite/msg_serverstatus.go 85.71% <100.00%> (ø)
Flag Coverage Δ
hana ?
integration 71.59% <100.00%> (ø)
mongodb 5.25% <0.00%> (ø)
pg 64.65% <0.00%> (ø)
shard-1 55.82% <100.00%> (-0.12%) ⬇️
shard-2 54.68% <100.00%> (ø)
shard-3 55.92% <100.00%> (ø)
sqlite 46.99% <100.00%> (ø)
unit 24.50% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlekSi AlekSi added this to the Next milestone Aug 29, 2023
@AlekSi AlekSi enabled auto-merge (squash) August 29, 2023 04:42
@AlekSi AlekSi merged commit eccf40d into FerretDB:main Aug 29, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Update TODO comments (FerretDB#3262)
63571d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@noisersup @AlekSi @chilagrow