Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and deprecate commonerrors.WriteErrors #3258

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Simplify and deprecate commonerrors.WriteErrors #3258

merged 8 commits into from
Aug 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 28, 2023 •
edited
Loading

Description

Closes #2750.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 28, 2023
@AlekSi AlekSi self-assigned this Aug 28, 2023
@AlekSi AlekSi added this to the Next milestone Aug 28, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #3258 (7012ad6) into main (eccf40d) will increase coverage by 0.00%.
The diff coverage is 72.22%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3258   +/-   ##
=======================================
  Coverage   75.17%   75.18%           
=======================================
  Files         400      399    -1     
  Lines       22386    22378    -8     
=======================================
- Hits        16829    16824    -5     
+ Misses       4580     4575    -5     
- Partials      977      979    +2
Files Changed Coverage Δ
...ggregations/operators/accumulators/accumulators.go 84.78% <ø> (-0.33%) ⬇️
internal/handlers/common/update.go 89.39% <0.00%> (ø)
internal/handlers/commonerrors/error.go 88.23% <ø> (ø)
internal/clientconn/conn.go 55.84% <71.42%> (+0.05%) ⬆️
internal/handlers/commonerrors/write.go 84.21% <83.33%> (+3.61%) ⬆️
internal/handlers/commonerrors/command.go 94.44% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.61% <72.22%> (+0.01%) ⬆️
mongodb 5.26% <0.00%> (+<0.01%) ⬆️
pg 64.66% <72.22%> (+<0.01%) ⬆️
shard-1 55.92% <61.11%> (+0.09%) ⬆️
shard-2 54.74% <66.66%> (+0.06%) ⬆️
shard-3 55.93% <72.22%> (+<0.01%) ⬆️
sqlite 47.00% <55.55%> (+<0.01%) ⬆️
unit 24.58% <16.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Simplify write errors Simplify commonerrors.WriteErrors Aug 28, 2023
@AlekSi AlekSi changed the title Simplify commonerrors.WriteErrors Simplify and deprecate commonerrors.WriteErrors Aug 28, 2023
@AlekSi AlekSi marked this pull request as ready for review August 28, 2023 18:13
@AlekSi AlekSi requested a review from a team as a code owner August 28, 2023 18:13
@AlekSi AlekSi enabled auto-merge (squash) August 28, 2023 18:13
@AlekSi AlekSi requested review from a team and noisersup August 28, 2023 18:13
chilagrow
chilagrow reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a linter warning for deprecated function

internal/handlers/commonerrors/write.go Outdated Show resolved Hide resolved
@AlekSi
Copy link
Member Author

AlekSi commented Aug 29, 2023

There is a linter warning for deprecated function

Unfortunately, we can't fix it in this PR because of the way we use that linter and two separate configurations for golangci-lint. That code is considered new (it does not exist in the main branch), and our config disallows the usage of deprecated symbols in the new code.

That will not be a problem once this PR is merged.

@AlekSi AlekSi requested review from chilagrow and a team August 29, 2023 05:01
chilagrow
chilagrow approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@AlekSi AlekSi disabled auto-merge August 29, 2023 05:41
@AlekSi AlekSi merged commit 7d4a15e into FerretDB:main Aug 29, 2023
@AlekSi AlekSi deleted the write-errors branch August 29, 2023 05:41
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Simplify and deprecate commonerrors.WriteErrors (FerretDB#3258)
57bfdb3 
Closes FerretDB#2750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Support ordered inserts for SQLite
2 participants
@AlekSi @chilagrow