Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aggregate for SQLite #3256

Merged
merged 12 commits into from
Aug 29, 2023
Merged

Implement aggregate for SQLite #3256

merged 12 commits into from
Aug 29, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 28, 2023 •
edited
Loading

Description

Closes #3148.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #3256 (a00cd20) into main (7d4a15e) will increase coverage by 0.10%.
The diff coverage is 84.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
+ Coverage   75.17%   75.28%   +0.10%     
==========================================
  Files         399      399              
  Lines       22378    22633     +255     
==========================================
+ Hits        16823    17039     +216     
- Misses       4576     4607      +31     
- Partials      979      987       +8
Files Changed Coverage Δ
internal/handlers/pg/msg_aggregate.go 88.28% <ø> (ø)
internal/handlers/sqlite/msg_aggregate.go 84.88% <84.82%> (-15.12%) ⬇️
Flag Coverage Δ
integration 71.75% <84.82%> (+0.14%) ⬆️
mongodb 5.20% <0.00%> (-0.06%) ⬇️
pg 63.93% <0.00%> (-0.74%) ⬇️
shard-1 56.04% <63.03%> (+0.08%) ⬆️
shard-2 54.66% <53.30%> (-0.02%) ⬇️
shard-3 55.94% <55.64%> (+0.01%) ⬆️
sqlite 53.91% <84.82%> (+6.91%) ⬆️
unit 24.24% <0.00%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Aug 28, 2023
@chilagrow chilagrow modified the milestone: Next Aug 28, 2023
@chilagrow chilagrow marked this pull request as ready for review August 28, 2023 10:53
@chilagrow chilagrow requested a review from a team as a code owner August 28, 2023 10:53
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup August 28, 2023 10:53
@chilagrow chilagrow enabled auto-merge (squash) August 28, 2023 10:57
@mergify
Copy link
Contributor

mergify bot commented Aug 28, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Aug 28, 2023
@chilagrow chilagrow closed this Aug 29, 2023
auto-merge was automatically disabled August 29, 2023 02:16

Pull request was closed

@mergify mergify bot removed the conflict PRs that have merge conflicts label Aug 29, 2023
@chilagrow chilagrow reopened this Aug 29, 2023
@chilagrow
Copy link
Member Author

Github PR was running in degraded mode. Closing and re-opening PR appears to pickup latest commits on this PR.

@chilagrow chilagrow enabled auto-merge (squash) August 29, 2023 02:19
@chilagrow chilagrow requested a review from noisersup August 29, 2023 02:30
@AlekSi AlekSi requested review from AlekSi and a team August 29, 2023 05:03
@chilagrow chilagrow requested a review from AlekSi August 29, 2023 05:37
rumyantseva
rumyantseva approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chilagrow chilagrow merged commit 43b5a56 into FerretDB:main Aug 29, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@chilagrow @yonarw
Implement aggregate for SQLite (FerretDB#3256)
a5ad4bf 
Closes FerretDB#3148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Implement aggregate for SQLite
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup