Remove duplicated $expr tests
#3255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 75.26% 75.16% -0.11%
==========================================
Files 400 400
Lines 22386 22386
==========================================
- Hits 16849 16826 -23
- Misses 4563 4582 +19
- Partials 974 978 +4 see 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
commented
Aug 28, 2023
| "github.com/FerretDB/FerretDB/integration/shareddata" | ||
| ) | ||
|
|
||
| func TestAggregateMatchExprErrors(tt *testing.T) { |
There was a problem hiding this comment.
chilagrow
commented
Aug 28, 2023
| @@ -29,124 +29,11 @@ func TestAggregateCompatMatchExpr(t *testing.T) { | |||
| bson.D{{"$match", bson.D{{"$expr", "$v"}}}}, | |||
| }, | |||
| }, | |||
| "ExpressionDotNotation": { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compat tests and integration tests for
$exprin$matchstage behaves exactly likefindcommand with$expr. Let's remove duplicated tests, they are covered by https://github.com/FerretDB/FerretDB/blob/main/integration/query_evaluation_compat_test.go#L308 and https://github.com/FerretDB/FerretDB/blob/main/integration/query_evaluation_test.go#L93We do not want unnecessary tests which slows down our integration tests, see #3163 (comment)
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.