Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for accessing aggregation variable $$ROOT field #3254

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 28, 2023

Description

Closes #1992.

It adds tests, the issue should remain open.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Aug 28, 2023
@chilagrow chilagrow self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #3254 (cdc23a9) into main (a71936d) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3254      +/-   ##
==========================================
- Coverage   75.26%   75.20%   -0.06%     
==========================================
  Files         400      400              
  Lines       22386    22386              
==========================================
- Hits        16849    16836      -13     
- Misses       4563     4575      +12     
- Partials      974      975       +1     

see 4 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.62% <ø> (-0.08%) ⬇️
mongodb 5.25% <ø> (ø)
pg 64.68% <ø> (-0.07%) ⬇️
shard-1 56.74% <ø> (ø)
shard-2 56.09% <ø> (-0.19%) ⬇️
shard-3 54.87% <ø> (-0.06%) ⬇️
sqlite 46.99% <ø> (-0.05%) ⬇️
unit 24.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added this to the Next milestone Aug 28, 2023
@chilagrow chilagrow marked this pull request as ready for review August 28, 2023 07:39
@chilagrow chilagrow requested a review from a team as a code owner August 28, 2023 07:39
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup August 28, 2023 07:39
@chilagrow chilagrow enabled auto-merge (squash) August 28, 2023 07:39
@AlekSi AlekSi modified the milestones: v1.9.0, Next Aug 28, 2023
@AlekSi AlekSi disabled auto-merge August 28, 2023 11:49
@AlekSi AlekSi merged commit 62809bb into FerretDB:main Aug 28, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement ROOT aggregation system variable
3 participants