Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for explain #3236

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Add stubs for explain #3236

merged 3 commits into from
Aug 23, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 22, 2023

Description

Closes #3050.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3236 (734d726) into main (7049116) will decrease coverage by 70.42%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3236       +/-   ##
==========================================
- Coverage   75.71%   5.29%   -70.42%     
==========================================
  Files         396     393        -3     
  Lines       22219   21976      -243     
==========================================
- Hits        16823    1164    -15659     
- Misses       4426   20730    +16304     
+ Partials      970      82      -888     
Files Changed Coverage Δ
internal/backends/collection.go 0.00% <0.00%> (-100.00%) ⬇️
internal/backends/sqlite/collection.go 0.00% <0.00%> (-64.57%) ⬇️
internal/handlers/sqlite/msg_explain.go 0.00% <0.00%> (-86.67%) ⬇️

... and 303 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 5.29% <0.00%> (-66.84%) ⬇️
mongodb 5.29% <0.00%> (-0.01%) ⬇️
pg ?
shard-1 5.29% <0.00%> (-51.55%) ⬇️
shard-2 ?
shard-3 ?
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 22, 2023
@AlekSi AlekSi added this to the Next milestone Aug 22, 2023
@AlekSi AlekSi marked this pull request as ready for review August 22, 2023 15:58
@AlekSi AlekSi requested a review from a team as a code owner August 22, 2023 15:58
@AlekSi AlekSi enabled auto-merge (squash) August 22, 2023 15:58
@AlekSi AlekSi requested review from a team and noisersup August 22, 2023 15:58
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuzzing needs to be addressed

@AlekSi AlekSi disabled auto-merge August 23, 2023 11:40
@AlekSi AlekSi merged commit 2f55169 into FerretDB:main Aug 23, 2023
@AlekSi AlekSi deleted the explain-stub branch August 23, 2023 11:40
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement basic explain for SQLite
2 participants