Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stubs for renameCollection #3233

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 22, 2023

Description

Closes #2760.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 22, 2023
@AlekSi AlekSi added this to the Next milestone Aug 22, 2023
@AlekSi AlekSi self-assigned this Aug 22, 2023
@AlekSi AlekSi requested a review from a team as a code owner August 22, 2023 12:11
@AlekSi AlekSi enabled auto-merge (squash) August 22, 2023 12:12
@AlekSi AlekSi requested review from a team and noisersup August 22, 2023 12:12
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #3233 (3e75639) into main (36ce153) will decrease coverage by 0.09%.
The diff coverage is 25.92%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   75.76%   75.67%   -0.09%     
==========================================
  Files         396      396              
  Lines       22196    22219      +23     
==========================================
- Hits        16816    16814       -2     
- Misses       4409     4434      +25     
  Partials      971      971              
Files Changed Coverage Δ
internal/backends/database.go 77.77% <0.00%> (-22.23%) ⬇️
internal/backends/sqlite/database.go 72.72% <0.00%> (-5.33%) ⬇️
internal/backends/sqlite/metadata/registry.go 59.05% <70.00%> (-0.25%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.07% <25.92%> (-0.10%) ⬇️
mongodb 5.29% <0.00%> (-0.01%) ⬇️
pg 65.10% <0.00%> (-0.11%) ⬇️
shard-1 56.82% <25.92%> (-0.06%) ⬇️
shard-2 55.43% <25.92%> (-0.13%) ⬇️
shard-3 56.18% <25.92%> (-0.05%) ⬇️
sqlite 47.33% <25.92%> (-0.05%) ⬇️
unit 24.69% <25.92%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge August 22, 2023 12:28
@AlekSi AlekSi merged commit c392516 into FerretDB:main Aug 22, 2023
@AlekSi AlekSi deleted the rename-collection branch August 22, 2023 12:28
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement renameCollection for SQLite
2 participants