Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metrics for *sql.DB #3230

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Add more metrics for *sql.DB #3230

merged 4 commits into from
Aug 23, 2023

Conversation

slavabobik
Copy link
Contributor

@slavabobik slavabobik commented Aug 21, 2023 •
edited
Loading

Description

Added missing metrics for the *sql.DB pool statistics.

Closes #2909.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@slavabobik slavabobik requested a review from a team as a code owner August 21, 2023 17:45
@slavabobik slavabobik requested review from AlekSi and chilagrow August 21, 2023 17:45
@CLAassistant
Copy link

CLAassistant commented Aug 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@slavabobik slavabobik force-pushed the add-more-sql-metrics branch from e393c4b to 276cfc9 Compare August 21, 2023 18:08
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #3230 (2bc0488) into main (7049116) will decrease coverage by 22.85%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3230       +/-   ##
===========================================
- Coverage   75.71%   52.87%   -22.85%     
===========================================
  Files         396      396               
  Lines       22219    22276       +57     
===========================================
- Hits        16823    11778     -5045     
- Misses       4426     9669     +5243     
+ Partials      970      829      -141
Files Changed Coverage Δ
internal/backends/sqlite/metadata/registry.go 59.05% <0.00%> (ø)
internal/util/fsql/metrics.go 6.93% <0.00%> (-8.98%) ⬇️

... and 128 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 43.88% <0.00%> (-28.25%) ⬇️
mongodb 5.28% <0.00%> (-0.02%) ⬇️
pg ?
shard-1 36.77% <0.00%> (-20.06%) ⬇️
shard-2 ?
shard-3 37.89% <0.00%> (-18.36%) ⬇️
sqlite 43.79% <0.00%> (-3.57%) ⬇️
unit 24.63% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Aug 22, 2023
@AlekSi AlekSi added this to the Next milestone Aug 22, 2023
@AlekSi AlekSi enabled auto-merge (squash) August 22, 2023 08:46
auto-merge was automatically disabled August 22, 2023 10:39

Head branch was pushed to by a user without write access

@slavabobik slavabobik requested a review from AlekSi August 22, 2023 11:17
@AlekSi AlekSi merged commit a78b98a into FerretDB:main Aug 23, 2023
@AlekSi
Copy link
Member

AlekSi commented Aug 23, 2023

Thank you!

yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@slavabobik @yonarw
Add more metrics for *sql.DB (FerretDB#3230)
7be1039 
Closes FerretDB#2909.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@slavabobik slavabobik

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

Add more metrics for *sql.DB
3 participants
@slavabobik @CLAassistant @AlekSi