Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify commonerrors package #3227

Merged
merged 6 commits into from
Aug 24, 2023
Merged

Simplify commonerrors package #3227

merged 6 commits into from
Aug 24, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 21, 2023 •
edited
Loading

Description

Do not allow error unwrapping.

More to come.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 21, 2023
@AlekSi AlekSi added this to the Next milestone Aug 21, 2023
@AlekSi AlekSi self-assigned this Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Merging #3227 (815ef83) into main (2f55169) will decrease coverage by 0.09%.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
- Coverage   75.44%   75.36%   -0.09%     
==========================================
  Files         396      397       +1     
  Lines       22288    22291       +3     
==========================================
- Hits        16816    16799      -17     
- Misses       4501     4516      +15     
- Partials      971      976       +5
Files Changed Coverage Δ
internal/handlers/commonerrors/error.go 88.23% <ø> (+8.23%) ⬆️
internal/handlers/commonerrors/write_error.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_update.go 72.05% <0.00%> (-6.35%) ⬇️
internal/util/observability/funccall.go 45.00% <40.00%> (-5.00%) ⬇️
internal/handlers/pg/msg_insert.go 85.84% <66.66%> (-2.58%) ⬇️
internal/handlers/common/find.go 100.00% <100.00%> (ø)
internal/handlers/commonerrors/command.go 94.44% <100.00%> (+0.15%) ⬆️
internal/handlers/commonerrors/write.go 80.59% <100.00%> (+2.21%) ⬆️

... and 5 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.79% <40.00%> (-0.06%) ⬇️
mongodb 5.27% <5.71%> (-0.01%) ⬇️
pg 64.83% <40.00%> (-0.07%) ⬇️
shard-1 56.67% <25.71%> (+0.01%) ⬆️
shard-2 55.10% <22.85%> (-0.20%) ⬇️
shard-3 55.94% <14.28%> (-0.08%) ⬇️
sqlite 47.17% <17.14%> (-0.03%) ⬇️
unit 24.59% <5.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 23, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 23, 2023
@AlekSi AlekSi marked this pull request as ready for review August 24, 2023 04:47
@AlekSi AlekSi requested a review from a team as a code owner August 24, 2023 04:47
@AlekSi AlekSi enabled auto-merge (squash) August 24, 2023 04:47
@AlekSi AlekSi requested review from a team and noisersup August 24, 2023 04:48
@AlekSi AlekSi disabled auto-merge August 24, 2023 12:00
@AlekSi AlekSi merged commit 73cba72 into FerretDB:main Aug 24, 2023
@AlekSi AlekSi deleted the error-wrapping branch August 24, 2023 12:01
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Simplify commonerrors package (FerretDB#3227)
5b4648c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AlekSi