Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ordered inserts for SQLite #3223

Merged
merged 20 commits into from
Aug 30, 2023
Merged

Support ordered inserts for SQLite #3223

merged 20 commits into from
Aug 30, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 18, 2023 •
edited
Loading

Description

Closes #2750.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 18, 2023
@AlekSi AlekSi added this to the Next milestone Aug 18, 2023
@mergify mergify bot assigned AlekSi Aug 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Aug 25, 2023
@AlekSi
Merge remote-tracking branch 'upstream/main' into faster-inserts
95db7d9 
# Conflicts:
#	integration/insert_compat_test.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Aug 25, 2023
@AlekSi AlekSi modified the milestones: v1.9.0, Next Aug 28, 2023
@AlekSi AlekSi changed the title Speed-up inserts for SQLite Support ordered inserts for SQLite Aug 29, 2023
@AlekSi AlekSi mentioned this pull request Aug 29, 2023
Closed
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Merging #3223 (27ffb53) into main (0f91017) will decrease coverage by 1.63%.
The diff coverage is 83.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   74.88%   73.26%   -1.63%     
==========================================
  Files         400      400              
  Lines       22799    22840      +41     
==========================================
- Hits        17074    16733     -341     
- Misses       4736     5103     +367     
- Partials      989     1004      +15
Files Changed Coverage
internal/backends/error.go ø
internal/backends/errorcode_string.go ø
internal/backends/postgresql/collection.go 0.00%
internal/backends/sqlite/collection.go 80.00%
internal/handlers/sqlite/msg_insert.go 84.93%
internal/backends/collection.go 100.00%
internal/handlers/sqlite/msg_update.go 100.00%
Flag Coverage Δ
hana ?
integration 69.63% <83.83%> (-1.75%) ⬇️
mongodb 5.14% <0.00%> (-0.02%) ⬇️
pg 55.99% <0.00%> (-7.47%) ⬇️
shard-1 55.91% <36.36%> (+0.23%) ⬆️
shard-2 54.63% <63.63%> (+0.25%) ⬆️
shard-3 41.19% <79.79%> (-14.35%) ⬇️
sqlite 54.70% <83.83%> (+0.66%) ⬆️
unit 24.83% <19.19%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Aug 29, 2023
@AlekSi AlekSi marked this pull request as ready for review August 30, 2023 04:16
@AlekSi AlekSi requested a review from a team as a code owner August 30, 2023 04:16
@AlekSi AlekSi enabled auto-merge (squash) August 30, 2023 04:16
@AlekSi AlekSi requested review from a team and noisersup August 30, 2023 04:17
chilagrow
chilagrow approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

rumyantseva
rumyantseva approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit b16fe1f into FerretDB:main Aug 30, 2023
@AlekSi AlekSi deleted the faster-inserts branch August 30, 2023 06:06
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Support ordered inserts for SQLite (FerretDB#3223)
d3a9abc 
Closes FerretDB#2750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.10.1
Development

Successfully merging this pull request may close these issues.

Support ordered inserts for SQLite
3 participants
@AlekSi @rumyantseva @chilagrow