Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrent SQLite tests #3222

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Fix concurrent SQLite tests #3222

merged 2 commits into from
Aug 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 17, 2023

Description

Closes #3172.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 17, 2023
@AlekSi AlekSi added this to the Next milestone Aug 17, 2023
@AlekSi AlekSi self-assigned this Aug 17, 2023
@AlekSi AlekSi requested a review from a team as a code owner August 17, 2023 12:57
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team and noisersup August 17, 2023 12:57
@AlekSi AlekSi enabled auto-merge (squash) August 17, 2023 12:58
@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Merging #3222 (a34419e) into main (39e53ed) will decrease coverage by 1.45%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3222      +/-   ##
==========================================
- Coverage   75.23%   73.78%   -1.45%     
==========================================
  Files         396      396              
  Lines       22210    22219       +9     
==========================================
- Hits        16709    16394     -315     
- Misses       4521     4812     +291     
- Partials      980     1013      +33
Files Changed Coverage Δ
integration/setup/startup.go 66.66% <ø> (-1.15%) ⬇️
internal/util/testutil/db.go 90.47% <ø> (ø)
integration/setup/listener.go 75.55% <100.00%> (+3.22%) ⬆️

... and 57 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 69.98% <100.00%> (-1.60%) ⬇️
mongodb 5.29% <0.00%> (-0.01%) ⬇️
pg 60.41% <9.09%> (-4.81%) ⬇️
shard-1 56.77% <100.00%> (+0.50%) ⬆️
shard-2 35.57% <100.00%> (-19.39%) ⬇️
shard-3 56.11% <100.00%> (+0.30%) ⬆️
sqlite 47.26% <100.00%> (+11.50%) ⬆️
unit 24.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

noisersup
noisersup approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are no tests that are failing due to the problem. I'll fix remaining tests LGTM

rumyantseva
rumyantseva approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit 30dc9fc into FerretDB:main Aug 17, 2023
@AlekSi AlekSi deleted the sqlite-subdirs branch August 17, 2023 20:24
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Fix concurrent SQLite tests (FerretDB#3222)
58c898c 
Closes FerretDB#3172.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

Fix SQLite unstable tests
3 participants
@AlekSi @rumyantseva @noisersup