Refactor aggregation accumulators #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noisersup this pull request has merge conflicts. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
==========================================
- Coverage 75.44% 75.40% -0.05%
==========================================
Files 396 397 +1
Lines 22288 22327 +39
==========================================
+ Hits 16816 16836 +20
- Misses 4501 4519 +18
- Partials 971 972 +1
... and 29 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
Aug 23, 2023
internal/handlers/common/aggregations/operators/accumulators/accumulators.go
Show resolved
Hide resolved
AlekSi
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3129.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.