Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post on MongoDB sorting for scalar values #3200

Merged
merged 33 commits into from
Oct 31, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 15, 2023

Description

Closes FerretDB/engineering#44.

To make reviewing easier by deploying it to cloudflare, I removed draft: true and added do not merge label.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #3200 (418d3e3) into main (60a9bcc) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   74.63%   74.14%   -0.50%     
==========================================
  Files         370      370              
  Lines       23564    23564              
==========================================
- Hits        17588    17472     -116     
- Misses       4962     5063     +101     
- Partials     1014     1029      +15     

see 12 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 70.21% <ø> (-0.48%) ⬇️
hana-1 3.49% <ø> (ø)
integration 70.21% <ø> (-0.53%) ⬇️
mongodb-1 5.29% <ø> (ø)
postgresql-1 50.72% <ø> (-0.46%) ⬇️
postgresql-2 50.21% <ø> (-0.26%) ⬇️
postgresql-3 49.10% <ø> (-0.24%) ⬇️
sort-false 70.21% <ø> (-0.09%) ⬇️
sort-true ?
sqlite-1 50.24% <ø> (-0.53%) ⬇️
sqlite-2 49.48% <ø> (-0.27%) ⬇️
sqlite-3 48.36% <ø> (-0.19%) ⬇️
unit 28.92% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added blog/engineering Engineering blog posts trust PRs that can access Actions secrets labels Aug 15, 2023
@mergify mergify bot requested review from AlekSi, Fashander, noisersup, ptrfarkas, rumyantseva and a team August 15, 2023 05:47
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

Engineering blog posts should be reviewed by other engineers and @Fashander.

@chilagrow chilagrow had a problem deploying to cloudflare-dev-blog August 16, 2023 07:43 — with GitHub Actions Failure
@chilagrow chilagrow had a problem deploying to cloudflare-dev-blog August 16, 2023 07:56 — with GitHub Actions Failure
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and briefly!

@mergify mergify bot requested a review from a team October 27, 2023 14:26
noisersup
noisersup previously approved these changes Oct 27, 2023
@mergify mergify bot requested a review from a team October 27, 2023 14:41
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@mergify mergify bot requested a review from a team October 31, 2023 10:40
@AlekSi AlekSi disabled auto-merge October 31, 2023 10:53
@AlekSi AlekSi merged commit ebf46cf into FerretDB:main Oct 31, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/engineering Engineering blog posts trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants