Add another stress test for SQLite #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
- Coverage 75.50% 72.08% -3.43%
==========================================
Files 396 396
Lines 22210 22210
==========================================
- Hits 16770 16009 -761
- Misses 4461 5164 +703
- Partials 979 1037 +58 see 64 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
AlekSi
reviewed
Aug 14, 2023
There was a problem hiding this comment.
staticcheck linter is correct there. It is hard to argue if there is a problem in FerretDB when the test itself is not correct.
Also, we don't use T{} form when there is nothing that possibly could be initialized (there are no exported fields). See also https://dave.cheney.net/practical-go/presentations/gophercon-singapore-2019.html#_use_a_consistent_declaration_style
AlekSi
added
the
not ready
AlekSi
removed
the
not ready
AlekSi
changed the title
AlekSi
approved these changes
Aug 17, 2023
yonarw
pushed a commit
to yonarw/FerretDB
that referenced
this pull request
Aug 31, 2023
Closes FerretDB#3172. Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@ferretdb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3172.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.