Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for $$ROOT #3187

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Add tests for $$ROOT #3187

merged 4 commits into from
Aug 11, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 10, 2023 •
edited
Loading

Description

Closes #1992.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Aug 10, 2023
@chilagrow chilagrow self-assigned this Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #3187 (f56d4eb) into main (74844b1) will increase coverage by 3.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3187      +/-   ##
==========================================
+ Coverage   70.95%   74.84%   +3.88%     
==========================================
  Files         396      396              
  Lines       22210    22210              
==========================================
+ Hits        15760    16623     +863     
+ Misses       5392     4609     -783     
+ Partials     1058      978      -80

see 74 files with indirect coverage changes

Flag Coverage Δ
integration 71.23% <ø> (+4.45%) ⬆️
mongodb 5.30% <ø> (ø)
pg 65.21% <ø> (+4.81%) ⬆️
shard-1 55.88% <ø> (-0.65%) ⬇️
shard-2 54.79% <ø> (?)
shard-3 55.12% <ø> (-0.80%) ⬇️
sqlite 33.15% <ø> (-1.91%) ⬇️
unit 24.51% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Add more tests for $$ROOT Add tests for $$ROOT Aug 10, 2023
@chilagrow chilagrow marked this pull request as ready for review August 10, 2023 09:42
@chilagrow chilagrow requested a review from a team as a code owner August 10, 2023 09:42
@chilagrow chilagrow requested a review from rumyantseva August 10, 2023 09:42
@chilagrow chilagrow enabled auto-merge (squash) August 10, 2023 09:42
@chilagrow chilagrow requested review from a team and noisersup August 10, 2023 09:42
rumyantseva
rumyantseva approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the additional examples!

noisersup
noisersup approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit 911d583 into FerretDB:main Aug 11, 2023
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@chilagrow @yonarw
Add tests for $$ROOT (FerretDB#3187)
50e10bf 
Closes FerretDB#1992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Implement ROOT aggregation system variable
4 participants
@chilagrow @rumyantseva @noisersup @AlekSi