Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make update integration tests pass for SQLite #3184

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Make update integration tests pass for SQLite #3184

merged 5 commits into from
Aug 10, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 9, 2023 •
edited
Loading

Description

  • update_compat_test.go

TestUpdateCompat fails for some subtests and passes for other subtests, it seems impossible to catch failure correctly without overcomplicating.

Closes #3131.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #3184 (226829e) into main (4384a3e) will decrease coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3184      +/-   ##
==========================================
- Coverage   75.30%   75.18%   -0.13%     
==========================================
  Files         396      396              
  Lines       22202    22202              
==========================================
- Hits        16719    16692      -27     
- Misses       4502     4534      +32     
+ Partials      981      976       -5

see 15 files with indirect coverage changes

Flag Coverage Δ
integration 71.54% <ø> (-0.12%) ⬇️
mongodb 5.30% <ø> (ø)
pg 65.20% <ø> (-0.01%) ⬇️
shard-1 56.47% <ø> (-0.30%) ⬇️
shard-2 54.77% <ø> (-0.39%) ⬇️
shard-3 55.80% <ø> (+0.10%) ⬆️
sqlite 36.03% <ø> (-2.50%) ⬇️
unit 24.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review August 10, 2023 12:51
@noisersup noisersup requested a review from a team as a code owner August 10, 2023 12:51
@noisersup noisersup enabled auto-merge (squash) August 10, 2023 12:51
@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Aug 10, 2023
@ptrfarkas ptrfarkas disabled auto-merge August 10, 2023 14:58
@ptrfarkas ptrfarkas merged commit cdd2f82 into FerretDB:main Aug 10, 2023
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
@AlekSi AlekSi mentioned this pull request Aug 22, 2023
Open
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Make update integration tests pass for SQLite (FerretDB#3184)
5533d1e 
Co-authored-by: Elena Grahovac <elena.grahovac@ferretdb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Make all integration tests "pass" with SQLite
4 participants
@noisersup @rumyantseva @AlekSi @ptrfarkas