Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for $$ROOT aggregation expression variable #3180

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Add tests for $$ROOT aggregation expression variable #3180

merged 5 commits into from
Aug 10, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Aug 9, 2023 •
edited
Loading

Description

Closes #1992.

This PR is the analysis of the task to add tests where expression would be used.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Aug 9, 2023
@chilagrow chilagrow self-assigned this Aug 9, 2023
@chilagrow chilagrow changed the title Add tests for $ROOT Add tests for $$ROOT aggregation expression variable Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Merging #3180 (91af2f8) into main (65a4379) will decrease coverage by 2.72%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
- Coverage   75.26%   72.55%   -2.72%     
==========================================
  Files         396      396              
  Lines       22202    22202              
==========================================
- Hits        16711    16108     -603     
- Misses       4503     5059     +556     
- Partials      988     1035      +47

see 60 files with indirect coverage changes

Flag Coverage Δ
integration 68.60% <ø> (-3.12%) ⬇️
mongodb 5.30% <ø> (ø)
pg 60.42% <ø> (-4.80%) ⬇️
shard-1 56.36% <ø> (+0.88%) ⬆️
shard-2 30.60% <ø> (-24.10%) ⬇️
shard-3 55.87% <ø> (-1.26%) ⬇️
sqlite 37.54% <ø> (+1.28%) ⬆️
unit 24.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review August 9, 2023 06:49
@chilagrow chilagrow requested a review from a team as a code owner August 9, 2023 06:49
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup August 9, 2023 06:49
@chilagrow chilagrow enabled auto-merge (squash) August 9, 2023 06:50
@chilagrow chilagrow mentioned this pull request Aug 9, 2023
Open
rumyantseva
rumyantseva approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit cc3e3ff into FerretDB:main Aug 10, 2023
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@chilagrow @yonarw
Add tests for $$ROOT aggregation expression variable (FerretDB#3180)
5cb1279 
Closes FerretDB#1992.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Implement ROOT aggregation system variable
4 participants
@chilagrow @rumyantseva @noisersup @AlekSi