Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getMore integration tests pass for SQLite #3174

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Make getMore integration tests pass for SQLite #3174

merged 7 commits into from
Aug 10, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 8, 2023 •
edited
Loading

Description

  • getmore_test.go
  • indexes_command_compat_test.go

Closes #3131.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #3174 (8422e8b) into main (cc3e3ff) will decrease coverage by 0.19%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
- Coverage   75.38%   75.20%   -0.19%     
==========================================
  Files         396      396              
  Lines       22202    22202              
==========================================
- Hits        16738    16697      -41     
- Misses       4480     4512      +32     
- Partials      984      993       +9

see 16 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.61% <ø> (-0.20%) ⬇️
mongodb 5.30% <ø> (ø)
pg 65.21% <ø> (ø)
shard-1 56.61% <ø> (+0.05%) ⬆️
shard-2 55.16% <ø> (-0.26%) ⬇️
shard-3 49.71% <ø> (-5.84%) ⬇️
sqlite 33.52% <ø> (-0.61%) ⬇️
unit 24.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup changed the title wip Make getMore integration tests pass for SQLite Aug 8, 2023
@noisersup noisersup marked this pull request as ready for review August 8, 2023 20:50
@noisersup noisersup requested a review from a team as a code owner August 8, 2023 20:50
@noisersup noisersup added the code/chore Code maintenance improvements label Aug 8, 2023
chilagrow
chilagrow previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

rumyantseva
rumyantseva previously approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Aug 10, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Aug 10, 2023
@noisersup noisersup enabled auto-merge (squash) August 10, 2023 12:31
rumyantseva
rumyantseva approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ptrfarkas ptrfarkas disabled auto-merge August 10, 2023 14:37
@ptrfarkas ptrfarkas merged commit 4384a3e into FerretDB:main Aug 10, 2023
@noisersup noisersup deleted the sqlite-tests-getmore-3131 branch August 10, 2023 15:20
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Make getMore integration tests pass for SQLite (FerretDB#3174)
1d1f086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Make all integration tests "pass" with SQLite
5 participants
@noisersup @rumyantseva @chilagrow @AlekSi @ptrfarkas