Do not return immutable _id error from findAndModify for upserting same _id
#3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3171 +/- ##
==========================================
- Coverage 75.41% 71.76% -3.66%
==========================================
Files 396 396
Lines 22202 22210 +8
==========================================
- Hits 16744 15939 -805
- Misses 4472 5229 +757
- Partials 986 1042 +56
... and 68 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
changed the title
_id check from findAndModify upsert option_id error from findAndModify for upsert different _id
This reverts commit 7977f3a.
chilagrow
changed the title
_id error from findAndModify for upsert different _id_id error from findAndModify for upserting same _id
rumyantseva
reviewed
Aug 9, 2023
noisersup
approved these changes
Aug 10, 2023
yonarw
pushed a commit
to yonarw/FerretDB
that referenced
this pull request
Aug 31, 2023
…g same `_id` (FerretDB#3171) Closes FerretDB#2803.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2803.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.