Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter for issue comments #3154

Merged
merged 18 commits into from
Aug 24, 2023
Merged

Add linter for issue comments #3154

merged 18 commits into from
Aug 24, 2023

Conversation

KrishnaSindhur
Copy link
Contributor

@KrishnaSindhur KrishnaSindhur commented Aug 3, 2023 •
edited
Loading

Description

Closes #2733.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@KrishnaSindhur KrishnaSindhur requested a review from AlekSi as a code owner August 3, 2023 09:12
@KrishnaSindhur KrishnaSindhur marked this pull request as draft August 3, 2023 09:12
@codecov
Copy link

codecov bot commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #3154 (ef3376d) into main (3d33c03) will decrease coverage by 49.28%.
The diff coverage is 14.63%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3154       +/-   ##
===========================================
- Coverage   75.43%   26.16%   -49.28%     
===========================================
  Files         396      396               
  Lines       22288    22300       +12     
===========================================
- Hits        16814     5834    -10980     
- Misses       4501    15911    +11410     
+ Partials      973      555      -418
Files Changed Coverage Δ
integration/setup/setup.go 75.84% <ø> (-3.94%) ⬇️
integration/setup/setup_compat.go 11.01% <ø> (-81.36%) ⬇️
integration/shareddata/faker.go 0.00% <0.00%> (ø)
internal/bson/datetime.go 67.85% <ø> (ø)
internal/clientconn/cursor/registry.go 39.81% <ø> (-51.86%) ⬇️
...l/handlers/common/aggregations/stages/collstats.go 0.00% <0.00%> (-85.00%) ⬇️
...ommon/aggregations/stages/projection/projection.go 0.00% <0.00%> (-86.98%) ⬇️
...ternal/handlers/common/aggregations/stages/sort.go 0.00% <ø> (-100.00%) ⬇️
internal/handlers/common/delete.go 0.00% <ø> (-100.00%) ⬇️
internal/handlers/common/filter.go 0.00% <0.00%> (-84.11%) ⬇️
... and 25 more

... and 195 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 5.28% <0.00%> (-66.59%) ⬇️
mongodb 5.28% <0.00%> (-0.01%) ⬇️
pg ?
shard-1 5.28% <0.00%> (-51.39%) ⬇️
shard-2 ?
shard-3 ?
sqlite ?
unit 24.61% <15.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KrishnaSindhur KrishnaSindhur marked this pull request as ready for review August 3, 2023 11:41
@KrishnaSindhur KrishnaSindhur requested a review from a team as a code owner August 3, 2023 11:41
@AlekSi AlekSi added this to the Next milestone Aug 3, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 3, 2023
@AlekSi AlekSi requested review from a team, chilagrow and noisersup August 3, 2023 13:20
noisersup
noisersup reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution! There are some small tweaks that I'd suggest to apply

tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/testdata/testdata.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
@AlekSi AlekSi modified the milestones: v1.8.0, Next Aug 14, 2023
noisersup
noisersup requested changes Aug 16, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! The linter seems to catch invalid TODOs, I have some suggessions, but apart from them it looks good to me!

Also, please run task fmt to format the code

tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
@AlekSi AlekSi mentioned this pull request Aug 17, 2023
Closed
@AlekSi AlekSi changed the title add: lint check for issue comment Add linter for issue comments Aug 17, 2023
rumyantseva
rumyantseva reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see the check implemented!

I see some TODOs were identified by the linter, and also the line/position of the detected problem is not reported. Is it for a separate PR?

tools/checkissuecomment/checkissuecomment.go Outdated Show resolved Hide resolved
@AlekSi AlekSi assigned AlekSi and unassigned noisersup Aug 24, 2023
AlekSi
AlekSi previously approved these changes Aug 24, 2023
View reviewed changes
@AlekSi AlekSi merged commit 093be98 into FerretDB:main Aug 24, 2023
@AlekSi
Copy link
Member

AlekSi commented Aug 24, 2023

Thank you!

This was referenced Aug 29, 2023
Closed
Closed
Merged
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@KrishnaSindhur @yonarw
Add linter for issue comments (FerretDB#3154)
6ec80b3 
Closes FerretDB#2733.

Co-authored-by: KrishnaSindhur <krishnasindhur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@AlekSi AlekSi

@KrishnaSindhur KrishnaSindhur

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

Make linter for checking that linked issues are open
4 participants
@KrishnaSindhur @AlekSi @rumyantseva @noisersup