Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make administration command integration tests pass for SQLite #3152

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Make administration command integration tests pass for SQLite #3152

merged 4 commits into from
Aug 3, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 2, 2023 •
edited
Loading

Description

  • commands_administration_compat_test.go
  • commands_administration_test.go
  • commands_authentication_test.go
  • commands_diagnostic_test.go

Closes #3131.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Aug 2, 2023
@noisersup noisersup self-assigned this Aug 2, 2023
@noisersup noisersup added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 2, 2023
@noisersup noisersup marked this pull request as ready for review August 2, 2023 15:43
@noisersup noisersup requested a review from a team as a code owner August 2, 2023 15:43
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and chilagrow August 2, 2023 15:43
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #3152 (dc7a6a8) into main (7809e6e) will decrease coverage by 0.34%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3152      +/-   ##
==========================================
- Coverage   75.33%   75.00%   -0.34%     
==========================================
  Files         393      393              
  Lines       21873    21873              
==========================================
- Hits        16479    16405      -74     
- Misses       4428     4507      +79     
+ Partials      966      961       -5

see 14 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.36% <ø> (-0.36%) ⬇️
mongodb 5.38% <ø> (ø)
pg 65.26% <ø> (-0.01%) ⬇️
shard-1 54.28% <ø> (-0.41%) ⬇️
shard-2 52.98% <ø> (-0.26%) ⬇️
shard-3 57.86% <ø> (-0.54%) ⬇️
sqlite 30.94% <ø> (-6.24%) ⬇️
unit 24.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup enabled auto-merge (squash) August 2, 2023 15:47
chilagrow
chilagrow reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check sqlite tests pass on those files please 🙏

integration/commands_administration_test.go Show resolved Hide resolved
integration/commands_administration_compat_test.go Show resolved Hide resolved
integration/commands_administration_test.go Show resolved Hide resolved
@chilagrow chilagrow self-requested a review August 3, 2023 09:00
chilagrow
chilagrow approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out the error looks like there is some flaky things with running sqlite test. All errors are the same so lets not block us

rumyantseva
rumyantseva approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noisersup noisersup merged commit 58fc918 into FerretDB:main Aug 3, 2023
@noisersup noisersup deleted the sqlite-tests-administration-3131 branch August 3, 2023 13:04
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Make administration command integration tests pass for SQLite (Ferret…
b6e8391 
…DB#3152)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Make all integration tests "pass" with SQLite
4 participants
@noisersup @rumyantseva @chilagrow @AlekSi