Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aggregate stats integration tests pass for SQLite #3151

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Make aggregate stats integration tests pass for SQLite #3151

merged 5 commits into from
Aug 3, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Aug 2, 2023 •
edited
Loading

Description

  • aggregate_documents_test.go
  • aggregate_stats_compat_test.go

Closes #3131.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup self-assigned this Aug 2, 2023
@noisersup noisersup added the code/chore Code maintenance improvements label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #3151 (9aa937d) into main (957a563) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   44.32%   44.16%   -0.17%     
==========================================
  Files         393      393              
  Lines       21873    21875       +2     
==========================================
- Hits         9696     9661      -35     
- Misses      11373    11420      +47     
+ Partials      804      794      -10
Files Changed Coverage Δ
integration/setup/test_helpers.go 93.33% <0.00%> (+0.47%) ⬆️

... and 35 files with indirect coverage changes

Flag Coverage Δ
integration 34.56% <0.00%> (-0.15%) ⬇️
mongodb 5.38% <0.00%> (-0.01%) ⬇️
shard-1 31.74% <0.00%> (-0.37%) ⬇️
shard-2 24.86% <0.00%> (+1.21%) ⬆️
shard-3 27.29% <0.00%> (-1.15%) ⬇️
sqlite 34.11% <0.00%> (-0.30%) ⬇️
unit 24.68% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review August 2, 2023 14:37
@noisersup noisersup requested a review from a team as a code owner August 2, 2023 14:37
@noisersup noisersup requested review from AlekSi, chilagrow, a team and rumyantseva August 2, 2023 14:37
@noisersup noisersup enabled auto-merge (squash) August 2, 2023 14:38
rumyantseva
rumyantseva previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, one tiny question.

integration/aggregate_stats_compat_test.go Show resolved Hide resolved
@noisersup noisersup requested a review from rumyantseva August 2, 2023 15:22
rumyantseva
rumyantseva previously approved these changes Aug 2, 2023
View reviewed changes
@noisersup noisersup force-pushed the sqlite-tests-aggregate-2-3131 branch from 3ef95ce to 337d675 Compare August 2, 2023 15:37
@noisersup noisersup requested a review from rumyantseva August 2, 2023 16:54
@chilagrow chilagrow self-requested a review August 3, 2023 09:01
chilagrow
chilagrow approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing CI tests were due to flakiness of sqlite. so it's good to go

rumyantseva
rumyantseva approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noisersup noisersup merged commit cb8a799 into FerretDB:main Aug 3, 2023
@noisersup noisersup deleted the sqlite-tests-aggregate-2-3131 branch August 3, 2023 13:34
@AlekSi AlekSi added this to the v1.8.0 milestone Aug 14, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@noisersup @yonarw
Make aggregate stats integration tests pass for SQLite (FerretDB#3151)
fa74625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Make all integration tests "pass" with SQLite
4 participants
@noisersup @rumyantseva @chilagrow @AlekSi