Make aggregate documents compat tests pass for SQLite #3150
Conversation
noisersup
added
the
not ready
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
==========================================
- Coverage 75.51% 75.17% -0.35%
==========================================
Files 395 395
Lines 21953 21953
==========================================
- Hits 16578 16503 -75
- Misses 4404 4472 +68
- Partials 971 978 +7 see 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
added
code/chore
noisersup
changed the title
There was a problem hiding this comment.
To be honest, I'm not sure if we need failsForSQLite param for aggregation test cases at all because aggregation is not supported, and it's enough to just fail all the aggregation tests. And also because aggregation is implemented through common, I expect it should be easy to enable it for SQLite. So, I guess as part of #3148 we will have to go through all these cases again and remove failsForSQLite.
However, potentially, there might be some stages that we won't enable/implement immediately, and, as this code does the job, I approve.
|
@noisersup this pull request has merge conflicts. |
Description
aggregate_documents_compat_test.goCloses #3131.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.