Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect some aggregate and insert tests to fail for SQLite #3147

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Expect some aggregate and insert tests to fail for SQLite #3147

merged 4 commits into from
Aug 2, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Aug 2, 2023 •
edited
Loading

Description

See #2750 and #3148.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Aug 2, 2023
@AlekSi AlekSi added this to the Next milestone Aug 2, 2023
@AlekSi AlekSi self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #3147 (54f5d17) into main (eb84add) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
- Coverage   75.53%   75.36%   -0.17%     
==========================================
  Files         393      393              
  Lines       21872    21873       +1     
==========================================
- Hits        16521    16485      -36     
- Misses       4388     4423      +35     
- Partials      963      965       +2
Files Changed Coverage Δ
internal/handlers/sqlite/msg_aggregate.go 100.00% <100.00%> (ø)

... and 23 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 71.73% <100.00%> (-0.25%) ⬇️
mongodb 5.38% <0.00%> (-0.01%) ⬇️
pg 65.23% <0.00%> (-0.04%) ⬇️
shard-1 54.92% <100.00%> (-0.18%) ⬇️
shard-2 53.40% <100.00%> (+0.02%) ⬆️
shard-3 58.33% <100.00%> (+0.23%) ⬆️
sqlite 37.32% <100.00%> (+2.40%) ⬆️
unit 24.68% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review August 2, 2023 10:00
@AlekSi AlekSi requested a review from a team as a code owner August 2, 2023 10:00
@AlekSi AlekSi requested review from rumyantseva and chilagrow August 2, 2023 10:00
@AlekSi AlekSi enabled auto-merge (squash) August 2, 2023 10:01
@AlekSi AlekSi requested review from a team and noisersup August 2, 2023 10:01
@AlekSi AlekSi changed the title Expect some insert tests to fail for SQLite Expect some aggregate and insert tests to fail for SQLite Aug 2, 2023
@AlekSi AlekSi disabled auto-merge August 2, 2023 10:30
@AlekSi AlekSi enabled auto-merge (squash) August 2, 2023 10:30
noisersup
noisersup approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that it works, LGTM

@AlekSi AlekSi disabled auto-merge August 2, 2023 11:03
@AlekSi AlekSi merged commit 7809e6e into FerretDB:main Aug 2, 2023
@AlekSi AlekSi deleted the expect-failure-subtests branch August 2, 2023 11:03
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Expect some aggregate and insert tests to fail for SQLite (Ferret…
98cdaca 
…DB#3147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlekSi @noisersup