Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak and document SQLite URI parameters #3128

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Tweak and document SQLite URI parameters #3128

merged 2 commits into from
Jul 28, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 28, 2023

Description

Closes #3084.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Jul 28, 2023
@AlekSi AlekSi self-assigned this Jul 28, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/enhancement Some user-visible feature could work better trust PRs that can access Actions secrets labels Jul 28, 2023
@AlekSi AlekSi marked this pull request as ready for review July 28, 2023 04:20
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners July 28, 2023 04:20
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 28, 2023 04:20
@AlekSi AlekSi enabled auto-merge (squash) July 28, 2023 04:20
@AlekSi AlekSi requested review from a team, noisersup and Fashander July 28, 2023 04:21
@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #3128 (c0d8554) into main (972aa85) will increase coverage by 0.14%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   75.83%   75.97%   +0.14%     
==========================================
  Files         392      392              
  Lines       21705    21726      +21     
==========================================
+ Hits        16459    16507      +48     
+ Misses       4294     4271      -23     
+ Partials      952      948       -4
Files Changed Coverage Δ
internal/backends/sqlite/metadata/pool/uri.go 88.46% <85.00%> (-2.17%) ⬇️
internal/handlers/pg/pgdb/pool.go 69.69% <100.00%> (+0.23%) ⬆️

... and 13 files with indirect coverage changes

Flag Coverage Δ
hana ∅ <ø> (∅)
integration 72.52% <73.80%> (+0.13%) ⬆️
mongodb 5.43% <0.00%> (-0.01%) ⬇️
pg 65.59% <42.85%> (-0.06%) ⬇️
shard-1 55.44% <73.80%> (-0.10%) ⬇️
shard-2 53.58% <73.80%> (-0.01%) ⬇️
shard-3 58.76% <73.80%> (+6.10%) ⬆️
sqlite 46.21% <30.95%> (+4.61%) ⬆️
unit 24.03% <92.85%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating documentation with default values as well 🙏

noisersup
noisersup approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi disabled auto-merge July 28, 2023 10:20
@AlekSi AlekSi merged commit fb189e8 into FerretDB:main Jul 28, 2023
@AlekSi AlekSi deleted the sqlite-uri branch July 28, 2023 10:20
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Tweak and document SQLite URI parameters (FerretDB#3128)
5703b30 
Closes FerretDB#3084.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@Fashander Fashander Awaiting requested review from Fashander Fashander was automatically assigned from FerretDB/docs

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Support for in-memory SQLite
3 participants
@AlekSi @chilagrow @noisersup