Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache SQLite tables metadata #3124

Merged
merged 26 commits into from
Jul 31, 2023
Merged

Cache SQLite tables metadata #3124

merged 26 commits into from
Jul 31, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 27, 2023 •
edited
Loading

Description

Closes #2747.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Jul 27, 2023
@AlekSi AlekSi self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #3124 (bfc1a75) into main (e6f325f) will decrease coverage by 0.67%.
The diff coverage is 71.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3124      +/-   ##
==========================================
- Coverage   75.96%   75.30%   -0.67%     
==========================================
  Files         392      393       +1     
  Lines       21750    21868     +118     
==========================================
- Hits        16523    16468      -55     
- Misses       4274     4432     +158     
- Partials      953      968      +15
Files Changed Coverage Δ
...nternal/clientconn/connmetrics/listener_metrics.go 90.24% <ø> (ø)
internal/util/state/metrics.go 100.00% <ø> (ø)
internal/util/testutil/teststress/stress.go 81.57% <25.00%> (-7.00%) ⬇️
internal/backends/sqlite/metadata/pool/pool.go 69.62% <56.75%> (-10.54%) ⬇️
internal/backends/sqlite/metadata/registry.go 64.97% <67.46%> (-1.18%) ⬇️
internal/util/fsql/db.go 95.45% <80.00%> (-4.55%) ⬇️
internal/backends/sqlite/collection.go 62.20% <91.66%> (+2.06%) ⬆️
internal/backends/sqlite/metadata/pool/uri.go 89.65% <100.00%> (+1.19%) ⬆️
internal/backends/sqlite/query_iterator.go 86.66% <100.00%> (+6.66%) ⬆️
internal/util/fsql/metrics.go 15.90% <100.00%> (ø)
... and 1 more

... and 16 files with indirect coverage changes

Flag Coverage Δ
integration 71.70% <66.66%> (-0.83%) ⬇️
mongodb 5.39% <0.44%> (-0.03%) ⬇️
pg 65.22% <0.44%> (-0.40%) ⬇️
shard-1 54.70% <66.66%> (-0.74%) ⬇️
shard-2 53.23% <66.22%> (-0.52%) ⬇️
shard-3 58.28% <66.66%> (-0.40%) ⬇️
sqlite 38.37% <66.66%> (-7.79%) ⬇️
unit 24.65% <55.55%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 27, 2023
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 27, 2023
@AlekSi
Merge branch 'main' into metadata-cache
facf2aa 
# Conflicts:
#	internal/backends/sqlite/metadata/pool/pool.go
#	internal/backends/sqlite/metadata/registry.go
#	internal/util/fsql/db.go
#	internal/util/fsql/metrics.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2023

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 28, 2023
@AlekSi
Merge branch 'main' into metadata-cache
1b23d5b 
# Conflicts:
#	internal/backends/sqlite/metadata/pool/pool_test.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 28, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 30, 2023
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Jul 31, 2023
@AlekSi AlekSi changed the title Metadata cache Cache SQLite tables metadata Jul 31, 2023
@AlekSi AlekSi marked this pull request as ready for review July 31, 2023 10:29
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners July 31, 2023 10:29
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 31, 2023 10:29
@AlekSi AlekSi enabled auto-merge (squash) July 31, 2023 10:29
@AlekSi AlekSi requested review from a team and noisersup July 31, 2023 10:29
@AlekSi AlekSi modified the milestones: v1.7.0, Next Jul 31, 2023
rumyantseva
rumyantseva approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi disabled auto-merge July 31, 2023 12:12
@AlekSi AlekSi merged commit 1bc1488 into FerretDB:main Jul 31, 2023
@AlekSi AlekSi deleted the metadata-cache branch July 31, 2023 12:13
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Cache SQLite tables metadata (FerretDB#3124)
752b9e0 
Closes FerretDB#2747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Implement metadata caching
3 participants
@AlekSi @rumyantseva @noisersup