Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic metrics, logging and tracing for SQLite #3123

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Add basic metrics, logging and tracing for SQLite #3123

merged 4 commits into from
Jul 27, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 26, 2023 •
edited
Loading

Description

More will be added later.

Closes #2909.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Jul 26, 2023
@AlekSi AlekSi self-assigned this Jul 26, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Merging #3123 (fecdf52) into main (a398e31) will decrease coverage by 0.14%.
The diff coverage is 55.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   75.94%   75.81%   -0.14%     
==========================================
  Files         391      392       +1     
  Lines       21596    21705     +109     
==========================================
+ Hits        16401    16455      +54     
- Misses       4240     4297      +57     
+ Partials      955      953       -2
Files Changed Coverage Δ
internal/backends/backend.go 90.69% <0.00%> (-9.31%) ⬇️
internal/handlers/sqlite/sqlite.go 66.66% <0.00%> (-5.34%) ⬇️
internal/util/fsql/metrics.go 15.90% <15.90%> (ø)
internal/backends/sqlite/backend.go 77.41% <20.00%> (-11.47%) ⬇️
internal/backends/sqlite/metadata/registry.go 68.46% <42.85%> (+1.00%) ⬆️
internal/backends/sqlite/metadata/pool/pool.go 74.04% <48.64%> (-10.72%) ⬇️
internal/backends/sqlite/collection.go 62.23% <100.00%> (ø)
internal/util/fsql/db.go 100.00% <100.00%> (ø)
Flag Coverage Δ
hana ?
integration 72.36% <55.41%> (-0.12%) ⬇️
mongodb 5.44% <0.00%> (-0.03%) ⬇️
pg 65.65% <0.00%> (-0.34%) ⬇️
shard-1 55.52% <55.41%> (-0.04%) ⬇️
shard-2 53.57% <55.41%> (-0.06%) ⬇️
shard-3 52.65% <0.00%> (-0.27%) ⬇️
sqlite 41.58% <55.41%> (+0.04%) ⬆️
unit 23.84% <24.20%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 26, 2023
@AlekSi AlekSi marked this pull request as ready for review July 26, 2023 18:11
@AlekSi AlekSi requested a review from a team as a code owner July 26, 2023 18:11
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 26, 2023 18:11
@AlekSi AlekSi enabled auto-merge (squash) July 26, 2023 18:11
@AlekSi AlekSi requested review from a team and noisersup July 26, 2023 18:12
chilagrow
chilagrow approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@AlekSi AlekSi mentioned this pull request Jul 27, 2023
Merged
9 tasks
rumyantseva
rumyantseva approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlekSi AlekSi merged commit 16d53f4 into FerretDB:main Jul 27, 2023
@AlekSi AlekSi deleted the sql-metrics-logs branch July 27, 2023 09:32
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
@AlekSi @yonarw
Add basic metrics, logging and tracing for SQLite (FerretDB#3123)
0acca85 
Closes FerretDB#2909.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Add more metrics for *sql.DB
3 participants
@AlekSi @rumyantseva @chilagrow