Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post on Grafana Monitoring for FerretDB #3106

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

Fashander
Copy link
Member

@Fashander Fashander commented Jul 25, 2023

Description

Closes FerretDB/engineering#77.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added do not merge PRs that should not be merged blog/marketing Marketing (and releases) blog posts labels Jul 25, 2023
@Fashander Fashander added this to the Next milestone Jul 25, 2023
@Fashander Fashander self-assigned this Jul 25, 2023
@Fashander Fashander added the trust PRs that can access Actions secrets label Jul 25, 2023
@Fashander Fashander enabled auto-merge (squash) July 25, 2023 09:46
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

Marketing blog posts should be reviewed by @ptrfarkas and @AlekSi.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3106 (9e030e0) into main (fb189e8) will decrease coverage by 70.47%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3106       +/-   ##
==========================================
- Coverage   75.90%   5.43%   -70.47%     
==========================================
  Files         392     389        -3     
  Lines       21726   21471      -255     
==========================================
- Hits        16491    1167    -15324     
- Misses       4282   20221    +15939     
+ Partials      953      83      -870     

see 302 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 5.43% <ø> (-67.06%) ⬇️
mongodb 5.43% <ø> (ø)
pg ?
shard-1 5.43% <ø> (-50.02%) ⬇️
shard-2 ?
shard-3 ?
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, left a few minor comments/quesitons

website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
Co-authored-by: Elena Grahovac <elena@grahovac.me>
rumyantseva
rumyantseva previously approved these changes Jul 28, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I especially like that we show particular examples and explain how they work.

To me, the wording and everything else look clear, but one more review from either Alexey or Peter is needed (as usual).

website/blog/2023-07-27-grafana-monitoring-ferretdb.md Outdated Show resolved Hide resolved
Co-authored-by: Elena Grahovac <elena@grahovac.me>
@AlekSi AlekSi disabled auto-merge July 28, 2023 11:47
@AlekSi AlekSi merged commit e6e791e into FerretDB:main Jul 28, 2023
yonarw pushed a commit to yonarw/FerretDB that referenced this pull request Aug 31, 2023
Closes FerretDB/engineering#77.

Co-authored-by: Elena Grahovac <elena@grahovac.me>
@Fashander Fashander deleted the ferretdb-grafana branch December 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/marketing Marketing (and releases) blog posts trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants