Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify checkdocs linter #3104

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Simplify checkdocs linter #3104

merged 4 commits into from
Jul 24, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 24, 2023

Description

That PR simplifies the linter's code to make it easier to add new checks.

It also fixes the checking of tags with spaces.

Closes #3078.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi requested a review from Fashander July 24, 2023 14:22
@mergify mergify bot assigned AlekSi Jul 24, 2023
@AlekSi AlekSi added this to the Next milestone Jul 24, 2023
@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements trust PRs that can access Actions secrets labels Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #3104 (c5e0a0f) into main (bb934e0) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3104   +/-   ##
=======================================
  Coverage   76.40%   76.41%           
=======================================
  Files         390      390           
  Lines       21312    21312           
=======================================
+ Hits        16284    16286    +2     
  Misses       4099     4099           
+ Partials      929      927    -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.91% <ø> (-0.01%) ⬇️
mongodb 5.48% <ø> (ø)
pg 66.36% <ø> (-0.01%) ⬇️
shard-1 56.77% <ø> (ø)
shard-2 54.92% <ø> (-0.03%) ⬇️
shard-3 56.89% <ø> (-0.12%) ⬇️
sqlite 46.41% <ø> (ø)
unit 24.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi had a problem deploying to cloudflare-dev-docs July 24, 2023 14:29 — with GitHub Actions Failure
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 24, 2023
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 24, 2023
@AlekSi AlekSi marked this pull request as ready for review July 24, 2023 15:52
@AlekSi AlekSi requested a review from ptrfarkas as a code owner July 24, 2023 15:52
@AlekSi AlekSi enabled auto-merge (squash) July 24, 2023 15:52
@AlekSi AlekSi requested review from a team, rumyantseva, quasilyte, chilagrow and noisersup July 24, 2023 15:52
@AlekSi AlekSi disabled auto-merge July 24, 2023 18:06
@AlekSi AlekSi merged commit 1924913 into FerretDB:main Jul 24, 2023
@AlekSi AlekSi deleted the simplify-check-docs branch July 24, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve checkdocs linter
3 participants