Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkdocs linter #3095

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Improve checkdocs linter #3095

merged 6 commits into from
Jul 24, 2023

Conversation

KrishnaSindhur
Copy link
Contributor

@KrishnaSindhur KrishnaSindhur commented Jul 20, 2023 •
edited
Loading

Description

Closes #3078.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@KrishnaSindhur KrishnaSindhur requested a review from AlekSi as a code owner July 20, 2023 19:08
@AlekSi AlekSi added this to the Next milestone Jul 20, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #3095 (0cf7fc7) into main (253c72f) will decrease coverage by 51.53%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3095       +/-   ##
==========================================
- Coverage   57.01%   5.48%   -51.53%     
==========================================
  Files         390     387        -3     
  Lines       21312   21057      -255     
==========================================
- Hits        12150    1155    -10995     
- Misses       8237   19819    +11582     
+ Partials      925      83      -842

see 226 files with indirect coverage changes

Flag Coverage Δ
integration 5.48% <ø> (-46.06%) ⬇️
mongodb 5.48% <ø> (ø)
pg ?
shard-1 5.48% <ø> (ø)
shard-3 ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@KrishnaSindhur KrishnaSindhur marked this pull request as draft July 21, 2023 07:39
@KrishnaSindhur KrishnaSindhur marked this pull request as ready for review July 21, 2023 08:12
@KrishnaSindhur KrishnaSindhur requested a review from AlekSi July 21, 2023 11:09
@KrishnaSindhur KrishnaSindhur changed the title add: lint check for date and tag Add: lint check for date and tag Jul 24, 2023
@AlekSi AlekSi changed the title Add: lint check for date and tag Improve checkdocs linter Jul 24, 2023
@AlekSi AlekSi enabled auto-merge (squash) July 24, 2023 12:41
@AlekSi AlekSi disabled auto-merge July 24, 2023 12:44
@AlekSi AlekSi merged commit 76578f5 into FerretDB:main Jul 24, 2023
@AlekSi
Copy link
Member

AlekSi commented Jul 24, 2023

Thank you!

@KrishnaSindhur KrishnaSindhur deleted the doc-lint-checker branch July 24, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees

@KrishnaSindhur KrishnaSindhur

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Improve checkdocs linter
2 participants
@KrishnaSindhur @AlekSi