Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed issue link and clean up integration test provider setup #3052

Merged
merged 7 commits into from
Jul 17, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 14, 2023

Description

Closes #2184.

This issue was already resolved by adding $sort before $group.

Also

  • added todo test
  • updated shareddata providers, AllProviders() include all of them, Remove providers compare providers not the name

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Jul 14, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #3052 (d465cdc) into main (70f33ed) will decrease coverage by 21.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3052       +/-   ##
===========================================
- Coverage   76.47%   55.39%   -21.08%     
===========================================
  Files         386      386               
  Lines       21155    21154        -1     
===========================================
- Hits        16178    11718     -4460     
- Misses       4051     8698     +4647     
+ Partials      926      738      -188     
Impacted Files Coverage Δ
integration/shareddata/shareddata.go 97.01% <100.00%> (-0.05%) ⬇️

... and 100 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 46.79% <100.00%> (-26.22%) ⬇️
mongodb 5.54% <100.00%> (-0.10%) ⬇️
pg ?
shard-1 35.80% <100.00%> (-18.95%) ⬇️
shard-2 36.54% <100.00%> (-18.56%) ⬇️
shard-3 38.32% <100.00%> (-19.39%) ⬇️
sqlite 46.70% <100.00%> (-0.05%) ⬇️
unit 24.21% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Remove link to resolved issue Clean up integration test provider setup Jul 14, 2023
@chilagrow chilagrow marked this pull request as ready for review July 14, 2023 08:26
@chilagrow chilagrow requested a review from a team as a code owner July 14, 2023 08:26
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team, quasilyte and noisersup July 14, 2023 08:26
@chilagrow chilagrow enabled auto-merge (squash) July 14, 2023 08:27
@chilagrow chilagrow changed the title Clean up integration test provider setup Remove fixed issue link and clean up integration test provider setup Jul 14, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi added this to the Next milestone Jul 17, 2023
@AlekSi AlekSi modified the milestones: v1.6.0, Next Jul 17, 2023
@chilagrow chilagrow merged commit fed08e6 into FerretDB:main Jul 17, 2023
@AlekSi AlekSi modified the milestones: Next, v1.6.0 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Aggregation tests for $group to return deterministic order in compat and target
3 participants