-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fixed issue link and clean up integration test provider setup #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3052 +/- ##
===========================================
- Coverage 76.47% 55.39% -21.08%
===========================================
Files 386 386
Lines 21155 21154 -1
===========================================
- Hits 16178 11718 -4460
- Misses 4051 8698 +4647
+ Partials 926 738 -188
... and 100 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
changed the title
Remove link to resolved issue
Clean up integration test provider setup
Jul 14, 2023
chilagrow
requested review from
AlekSi,
rumyantseva,
a team,
quasilyte and
noisersup
July 14, 2023 08:26
chilagrow
changed the title
Clean up integration test provider setup
Remove fixed issue link and clean up integration test provider setup
Jul 14, 2023
rumyantseva
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlekSi
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2184.
This issue was already resolved by adding
$sort
before$group
.Also
AllProviders()
include all of them,Remove
providers compare providers not the nameReadiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.