Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark some tests as failing for SQLite #3051

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Mark some tests as failing for SQLite #3051

merged 9 commits into from
Jul 18, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 13, 2023 •
edited
Loading

Description

To make them pass on CI eventually.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 13, 2023
@AlekSi AlekSi added this to the Next milestone Jul 13, 2023
@AlekSi AlekSi self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #3051 (f1b7c71) into main (c5f38c1) will increase coverage by 29.62%.
The diff coverage is 69.23%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3051       +/-   ##
===========================================
+ Coverage   25.86%   55.49%   +29.62%     
===========================================
  Files         386      386               
  Lines       21154    21165       +11     
===========================================
+ Hits         5472    11745     +6273     
+ Misses      15147     8685     -6462     
- Partials      535      735      +200
Impacted Files Coverage Δ
internal/handlers/pg/msg_explain.go 0.00% <0.00%> (ø)
internal/handlers/sqlite/msg_explain.go 86.66% <100.00%> (+86.66%) ⬆️

... and 130 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 46.90% <69.23%> (+41.35%) ⬆️
mongodb 5.54% <0.00%> (-0.01%) ⬇️
pg ?
shard-1 35.84% <69.23%> (+30.30%) ⬆️
shard-2 36.67% <69.23%> (∅)
shard-3 38.34% <69.23%> (∅)
sqlite 46.80% <69.23%> (∅)
unit 24.20% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 14, 2023 08:29
@AlekSi AlekSi requested a review from a team as a code owner July 14, 2023 08:29
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 14, 2023 08:29
@AlekSi AlekSi enabled auto-merge (squash) July 14, 2023 08:29
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 14, 2023 08:29
chilagrow
chilagrow previously approved these changes Jul 14, 2023
View reviewed changes
noisersup
noisersup previously approved these changes Jul 14, 2023
View reviewed changes
@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 14, 2023
@AlekSi AlekSi modified the milestones: v1.6.0, Next Jul 17, 2023
@AlekSi AlekSi dismissed stale reviews from noisersup and chilagrow via 278b5ce July 18, 2023 07:18
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 18, 2023
@AlekSi AlekSi requested a review from noisersup July 18, 2023 07:21
@AlekSi AlekSi requested review from chilagrow and a team July 18, 2023 07:21
@AlekSi AlekSi merged commit 873e07a into FerretDB:main Jul 18, 2023
@AlekSi AlekSi deleted the expect-failure branch July 18, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@quasilyte quasilyte Awaiting requested review from quasilyte quasilyte was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup