Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore count.fields argument #3048

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Ignore count.fields argument #3048

merged 2 commits into from
Jul 14, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 13, 2023

Description

Needed for NoSQLBooster.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 13, 2023
@AlekSi AlekSi added this to the Next milestone Jul 13, 2023
@AlekSi AlekSi requested a review from a team as a code owner July 13, 2023 16:44
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 13, 2023 16:44
@AlekSi AlekSi self-assigned this Jul 13, 2023
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 13, 2023 16:44
@AlekSi AlekSi enabled auto-merge (squash) July 13, 2023 16:44
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3048 (4b39607) into main (c6eccb4) will decrease coverage by 8.20%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3048      +/-   ##
==========================================
- Coverage   76.25%   68.06%   -8.20%     
==========================================
  Files         386      386              
  Lines       21095    21095              
==========================================
- Hits        16087    14358    -1729     
- Misses       4078     5801    +1723     
- Partials      930      936       +6     
Impacted Files Coverage Δ
internal/handlers/common/count.go 100.00% <ø> (ø)

... and 77 files with indirect coverage changes

Flag Coverage Δ
integration 64.02% <ø> (-8.76%) ⬇️
mongodb 5.41% <ø> (?)
pg 57.99% <ø> (-8.31%) ⬇️
shard-1 54.22% <ø> (+0.28%) ⬆️
shard-2 49.71% <ø> (-5.94%) ⬇️
shard-3 ?
sqlite 34.97% <ø> (-11.57%) ⬇️
unit 24.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi merged commit 21f9faf into FerretDB:main Jul 14, 2023
@AlekSi AlekSi deleted the ignore-field branch July 14, 2023 07:19
@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants