Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Type() interface from aggregation stage #3045

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Remove Type() interface from aggregation stage #3045

merged 5 commits into from
Jul 14, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 13, 2023 •
edited
Loading

Description

Closes #2423.

Just the easy part of removing Type() interface. The remaining part of moving $collStats specific logic out from msg_aggregation.go will be done part of task implementation.

Keep the issue open after this PR is merged.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #3045 (96b0e8c) into main (1352a47) will decrease coverage by 3.58%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3045      +/-   ##
==========================================
- Coverage   76.48%   72.90%   -3.58%     
==========================================
  Files         386      383       -3     
  Lines       21120    20840     -280     
==========================================
- Hits        16153    15193     -960     
- Misses       4048     4701     +653     
- Partials      919      946      +27
Impacted Files Coverage Δ
.../handlers/common/aggregations/stages/add_fields.go 75.00% <ø> (-1.93%) ⬇️
...l/handlers/common/aggregations/stages/collstats.go 85.00% <ø> (-0.49%) ⬇️
...ernal/handlers/common/aggregations/stages/count.go 100.00% <ø> (ø)
...ernal/handlers/common/aggregations/stages/group.go 88.67% <ø> (-0.15%) ⬇️
...ernal/handlers/common/aggregations/stages/limit.go 78.57% <ø> (-2.68%) ⬇️
...ernal/handlers/common/aggregations/stages/match.go 100.00% <ø> (ø)
...nal/handlers/common/aggregations/stages/project.go 100.00% <ø> (ø)
...nternal/handlers/common/aggregations/stages/set.go 75.00% <ø> (-1.93%) ⬇️
...ternal/handlers/common/aggregations/stages/skip.go 78.57% <ø> (-2.68%) ⬇️
...ternal/handlers/common/aggregations/stages/sort.go 100.00% <ø> (ø)
... and 3 more

... and 76 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.90% <100.00%> (-0.09%) ⬇️
mongodb 5.41% <0.00%> (+<0.01%) ⬆️
pg 66.27% <100.00%> (-0.06%) ⬇️
shard-1 54.23% <58.33%> (-0.06%) ⬇️
shard-2 55.76% <58.33%> (+0.11%) ⬆️
shard-3 57.09% <100.00%> (-0.01%) ⬇️
sqlite 46.61% <0.00%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow mentioned this pull request Jul 13, 2023
Open
5 tasks
@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 13, 2023
@chilagrow chilagrow marked this pull request as ready for review July 13, 2023 09:52
@chilagrow chilagrow requested a review from a team as a code owner July 13, 2023 09:52
@chilagrow chilagrow requested review from AlekSi and rumyantseva July 13, 2023 09:52
@chilagrow chilagrow enabled auto-merge (squash) July 13, 2023 09:52
@chilagrow chilagrow requested review from a team, quasilyte and noisersup July 13, 2023 09:53
@chilagrow chilagrow merged commit c6eccb4 into FerretDB:main Jul 14, 2023
@AlekSi AlekSi added this to the v1.6.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@quasilyte quasilyte Awaiting requested review from quasilyte quasilyte was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Move $collStats logic to its stage implementation
3 participants
@chilagrow @AlekSi @noisersup