Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note about setting the stable API version #3035

Merged
merged 8 commits into from
Jul 13, 2023
Merged

Add a note about setting the stable API version #3035

merged 8 commits into from
Jul 13, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jul 11, 2023 •
edited
Loading

Description

I am unsure if we should use more restrictive wording here because we don't know the extent of this issue.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@b1ron b1ron added the documentation Something user-visible is badly or not documented label Jul 11, 2023
@b1ron b1ron self-assigned this Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #3035 (b6d89b2) into main (2540a9f) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3035      +/-   ##
==========================================
- Coverage   76.50%   76.42%   -0.09%     
==========================================
  Files         386      386              
  Lines       21120    21120              
==========================================
- Hits        16157    16140      -17     
- Misses       4044     4058      +14     
- Partials      919      922       +3

see 5 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.92% <ø> (-0.10%) ⬇️
mongodb 5.41% <ø> (ø)
pg 66.32% <ø> (-0.04%) ⬇️
shard-1 54.21% <ø> (-0.10%) ⬇️
shard-2 55.76% <ø> (-0.07%) ⬇️
shard-3 57.10% <ø> (ø)
sqlite 46.53% <ø> (-0.07%) ⬇️
unit 24.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron requested review from a team and Fashander July 12, 2023 10:31
@b1ron b1ron marked this pull request as ready for review July 12, 2023 10:31
@b1ron b1ron requested review from AlekSi and ptrfarkas as code owners July 12, 2023 10:31
Fashander
Fashander reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a suggestion on the "note". Docusaurus has a built-in way for it.

@b1ron @Fashander
Update website/docs/security/authentication.md
f0d1a68 
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@b1ron b1ron requested a review from Fashander July 12, 2023 10:57
@b1ron b1ron enabled auto-merge (squash) July 12, 2023 10:57
Fashander
Fashander previously approved these changes Jul 12, 2023
View reviewed changes
AlekSi
AlekSi reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CI fails, probably due to trailing whitespace. Please run task docs-fmt and push results.

@b1ron b1ron requested a review from AlekSi July 13, 2023 12:47
@AlekSi AlekSi requested a review from Fashander July 13, 2023 12:49
@AlekSi AlekSi added this to the Next milestone Jul 13, 2023
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Jul 13, 2023
@b1ron b1ron merged commit 8e2abca into FerretDB:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@AlekSi AlekSi AlekSi approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@b1ron b1ron

Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@b1ron @AlekSi @Fashander