Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip findAndModify $set integration test for _id #3025

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Unskip findAndModify $set integration test for _id #3025

merged 3 commits into from
Jul 11, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 11, 2023 •
edited
Loading

Description

Closes #2741.

The validation was removed in #2803, this PR unskips the integration tests.

Test script #2743 passes.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 11, 2023
@chilagrow chilagrow self-assigned this Jul 11, 2023
@chilagrow chilagrow changed the title Unskip test Unskip findAndModify upsert test for $set _id Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #3025 (73ff2d9) into main (d4af935) will decrease coverage by 3.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
- Coverage   74.62%   71.52%   -3.11%     
==========================================
  Files         386      386              
  Lines       21056    21056              
==========================================
- Hits        15714    15060     -654     
- Misses       4401     5057     +656     
+ Partials      941      939       -2

see 54 files with indirect coverage changes

Flag Coverage Δ
integration 67.85% <ø> (-3.17%) ⬇️
mongodb 5.34% <ø> (ø)
pg 57.93% <ø> (-3.50%) ⬇️
shard-1 55.92% <ø> (ø)
shard-2 54.68% <ø> (+18.76%) ⬆️
shard-3 36.60% <ø> (-20.01%) ⬇️
sqlite 46.32% <ø> (-0.11%) ⬇️
unit 24.25% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Unskip findAndModify upsert test for $set _id Unskip findAndModify $set integration test for _id Jul 11, 2023
@chilagrow chilagrow requested review from a team, rumyantseva, quasilyte and noisersup July 11, 2023 07:05
@chilagrow chilagrow marked this pull request as ready for review July 11, 2023 07:05
@chilagrow chilagrow requested a review from a team as a code owner July 11, 2023 07:05
@chilagrow chilagrow requested a review from AlekSi July 11, 2023 07:05
@chilagrow chilagrow added code/bug Some user-visible feature works incorrectly and removed code/chore Code maintenance improvements labels Jul 11, 2023
@chilagrow chilagrow enabled auto-merge (squash) July 11, 2023 07:06
noisersup
noisersup approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

rumyantseva
rumyantseva approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chilagrow chilagrow merged commit 19cf543 into FerretDB:main Jul 11, 2023
@AlekSi AlekSi added this to the v1.6.0 milestone Jul 17, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/bug Some user-visible feature works incorrectly labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@quasilyte quasilyte Awaiting requested review from quasilyte quasilyte was automatically assigned from FerretDB/core

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Allow $set to work with _id field when upsert is performed
4 participants
@chilagrow @rumyantseva @noisersup @AlekSi