Make task all run only unit tests
#3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
added
project
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
===========================================
- Coverage 76.15% 25.76% -50.40%
===========================================
Files 385 385
Lines 21045 21045
===========================================
- Hits 16027 5422 -10605
- Misses 4090 15096 +11006
+ Partials 928 527 -401
... and 215 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
noisersup
reviewed
Jul 10, 2023
There was a problem hiding this comment.
I'm not sure if "all" is relevant here, as we skip the most important tests from all task "stages". Can't we leave task all as it is, but introduce a different task that would be also a default task?
It might be also good for us to tell contributors to use task in place of task xxx as we'll be able to just change the default task if we fix integration tests.
|
How to call this new target? |
noisersup
approved these changes
Jul 10, 2023
AlekSi
added
the
not ready
|
To pause Mergify for now |
chilagrow
approved these changes
Jul 11, 2023
quasilyte
approved these changes
Jul 11, 2023
AlekSi
removed
not ready
|
Yay, I've been waiting for this for two years now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make the PR template match reality.
For everyone to review.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.