Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move testutil.TB to testtb.TB #3022

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Move testutil.TB to testtb.TB #3022

merged 3 commits into from
Jul 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 10, 2023 •
edited
Loading

Description

That removes the import cycle in the next PR.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Move testutil.TB to testtb.TB
fb0605a 
That removes the import cycle in the next PR.
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 10, 2023
@AlekSi AlekSi added this to the Next milestone Jul 10, 2023
@AlekSi AlekSi self-assigned this Jul 10, 2023
@AlekSi AlekSi marked this pull request as ready for review July 10, 2023 14:33
@AlekSi AlekSi requested a review from a team as a code owner July 10, 2023 14:33
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 10, 2023 14:33
@AlekSi AlekSi enabled auto-merge (squash) July 10, 2023 14:33
@AlekSi AlekSi requested review from a team, quasilyte and noisersup July 10, 2023 14:34
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #3022 (cafab92) into main (7f4d831) will increase coverage by 0.01%.
The diff coverage is 87.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
+ Coverage   76.21%   76.23%   +0.01%     
==========================================
  Files         385      385              
  Lines       21045    21045              
==========================================
+ Hits        16039    16043       +4     
+ Misses       4080     4076       -4     
  Partials      926      926
Impacted Files Coverage Δ
internal/util/testutil/hexdump.go 20.00% <0.00%> (ø)
integration/setup/listener.go 72.78% <66.66%> (ø)
internal/util/testutil/dump.go 45.45% <66.66%> (ø)
internal/util/testutil/equal.go 58.44% <80.00%> (ø)
integration/setup/setup.go 79.77% <83.33%> (ø)
integration/helpers.go 84.70% <100.00%> (ø)
integration/setup/client.go 70.96% <100.00%> (ø)
integration/setup/setup_compat.go 92.37% <100.00%> (ø)
integration/setup/test_helpers.go 100.00% <100.00%> (ø)
internal/util/testutil/db.go 90.47% <100.00%> (ø)
... and 4 more

... and 6 files with indirect coverage changes

Flag Coverage Δ
hana ?
integration 72.74% <82.45%> (+0.01%) ⬆️
mongodb 5.34% <54.38%> (ø)
pg 66.19% <77.19%> (ø)
shard-1 55.21% <75.43%> (ø)
shard-2 55.48% <73.68%> (+0.06%) ⬆️
shard-3 56.66% <68.42%> (-0.07%) ⬇️
sqlite 45.90% <82.45%> (+0.01%) ⬆️
unit 24.26% <61.53%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

internal/util/testutil/testtb/tb.go Show resolved Hide resolved
@AlekSi AlekSi requested review from rumyantseva and a team July 10, 2023 15:57
@AlekSi AlekSi merged commit 8b32b84 into FerretDB:main Jul 11, 2023
@AlekSi AlekSi deleted the extract-package branch July 11, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@quasilyte quasilyte Awaiting requested review from quasilyte quasilyte was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup