Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logout to commoncommands #3019

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Move logout to commoncommands #3019

merged 3 commits into from
Jul 11, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 10, 2023 •
edited
Loading

Description

Just a small refactoring.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 10, 2023
@AlekSi AlekSi added this to the Next milestone Jul 10, 2023
@AlekSi AlekSi requested a review from a team as a code owner July 10, 2023 12:30
@AlekSi AlekSi self-assigned this Jul 10, 2023
@AlekSi AlekSi requested review from rumyantseva, chilagrow, a team, quasilyte and noisersup July 10, 2023 12:30
@AlekSi AlekSi enabled auto-merge (squash) July 10, 2023 12:31
@AlekSi AlekSi mentioned this pull request Jul 10, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #3019 (2557731) into main (8b32b84) will decrease coverage by 3.50%.
The diff coverage is 81.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   76.14%   72.65%   -3.50%     
==========================================
  Files         385      382       -3     
  Lines       21045    20790     -255     
==========================================
- Hits        16025    15105     -920     
- Misses       4090     4736     +646     
- Partials      930      949      +19
Impacted Files Coverage Δ
...rnal/handlers/commoncommands/msg_getcmdlineopts.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_logout.go 0.00% <0.00%> (ø)
internal/handlers/commoncommands/msg_buildinfo.go 100.00% <100.00%> (ø)
internal/handlers/commoncommands/msg_currentop.go 100.00% <100.00%> (ø)
internal/handlers/commoncommands/msg_debugerror.go 25.00% <100.00%> (ø)
internal/handlers/commoncommands/msg_hostinfo.go 76.56% <100.00%> (-3.13%) ⬇️
...ternal/handlers/commoncommands/msg_listcommands.go 100.00% <100.00%> (ø)
internal/handlers/commoncommands/msg_logout.go 100.00% <100.00%> (ø)
internal/handlers/commoncommands/msg_whatsmyuri.go 100.00% <100.00%> (ø)
internal/handlers/pg/msg_logout.go 100.00% <100.00%> (ø)
... and 1 more

... and 71 files with indirect coverage changes

Flag Coverage Δ
integration 72.65% <81.81%> (-0.01%) ⬇️
mongodb 5.34% <0.00%> (ø)
pg 66.18% <72.72%> (-0.01%) ⬇️
shard-1 55.21% <18.18%> (ø)
shard-2 55.42% <54.54%> (ø)
shard-3 56.65% <63.63%> (-0.01%) ⬇️
sqlite 45.82% <72.72%> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit c31e595 into FerretDB:main Jul 11, 2023
@AlekSi AlekSi deleted the move-common-command branch July 11, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte left review comments

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AlekSi @rumyantseva @quasilyte @chilagrow @noisersup